Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and fix financial overview year filter #2430

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

dev-rminds
Copy link
Contributor

@dev-rminds dev-rminds commented Dec 11, 2024

Changes description

Developers checklist

  • Autotests are passed locally
  • Migration rollback works - if there is migration, check rollback
  • Autotests are added:
    • bugfix - unit/feature test for this scenario if possible
    • new small/medium feature - simple feature test for positive scenarios

QA checklist

  • Translations are done
  • Endpoint is fast on dump - if there is new endpoint or changed query, endpoints that are using changed query - working fast on production dump, <2s

@lexlog lexlog added the Urgency: High needs to be reviewed during nearest days label Dec 11, 2024
@RobinMeles
Copy link
Contributor

Note from @dev-rminds is that he removed unused code in regards with fund top up provider balance, which cleaned up code in general.

@irinaBerendeeva87 Could you maybe help check the fund top ups if they work as supposed to? So having an active bank connection and check fund top up history under fund details:
image

@RobinMeles RobinMeles self-requested a review December 11, 2024 18:57
@RobinMeles
Copy link
Contributor

Re-checked PR based on this issue https://github.com/teamforus/DevOps/issues/1160:
✅ Fund page - shows remaining budget based on successful transactions
✅ Financial overview page - shows remaining budget based on successful transactions

Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked :
✅fund page shows remaining budget after successful transaction
✅on find page specific fund has changed balance.
✅ Financial overview page - shows remaining budget after successful transaction

@lexlog lexlog merged commit 5fc8d66 into develop Dec 13, 2024
2 checks passed
@lexlog lexlog deleted the restore-and-fix-financial-overview-year-filter branch December 13, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Urgency: High needs to be reviewed during nearest days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants