-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump intervention/image from 2.7.2 to 3.9.1 #2427
Bump intervention/image from 2.7.2 to 3.9.1 #2427
Conversation
The following labels could not be found: |
@dependabot rebase |
Bumps [intervention/image](https://github.com/Intervention/image) from 2.7.2 to 3.9.1. - [Release notes](https://github.com/Intervention/image/releases) - [Commits](Intervention/image@2.7.2...3.9.1) --- updated-dependencies: - dependency-name: intervention/image dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
a84b1da
to
0689503
Compare
@RobinMeles @lexlog @irinaBerendeeva87 This is a big update with a lot of breaking changes, migration to the latest version is comparable with switching to a different library. Therefore, there is a higher risk of something not working properly.
We already have some feature tests for medias (Tests\Feature\MediaUploadTest) but they don't cover the above points). |
@dependabot recreate |
7dadb11
to
1680e84
Compare
1680e84
to
0019573
Compare
….1 and fix the conflict
….1 and fix conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked:
✅ Images cropped properly (aspect ratio is correct and image is cropped to the center)
✅ Small images are upscaled to the required size where needed
✅ no errors in the console
Out of PR test:
- Image quality is as expected (same as the before update) will be fixed in another pr
After uploading the picture is blurred.
https://github.com/user-attachments/assets/a523eef0-82d6-4c43-b708-1228393642a2
@irinaBerendeeva87 will create an issue (and also add other places optionally)
Bumps intervention/image from 2.7.2 to 3.9.1.
Release notes
Sourced from intervention/image's releases.
... (truncated)
Commits
b496d1f
Add test assertions to validate the correct mime typef712d68
Fix typo in mime type. (#1399)3618c8f
Add .well-known directory to .gitattributesd09d985
Add funding-manifest-urls1e0a2b6
Add MediaType::fileExtensions() & MediaType::fileExtension()20ad74e
Add FileExtension::mediaType() & FileExtension::mediaTypes()57508a5
Add new method Format::fileExtension()4a5a7f6
Add method Format::mediaType()cfa0986
Format phpunit config file8cf0405
Pass mime type manually to avoid finfo dependencyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)