Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump intervention/image from 2.7.2 to 3.9.1 #2427

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 10, 2024

Bumps intervention/image from 2.7.2 to 3.9.1.

Release notes

Sourced from intervention/image's releases.

3.9.1

What's Changed

Full Changelog: Intervention/image@3.9.0...3.9.1

3.9.0

What's Changed

3.8.0

What's Changed

Full Changelog: Intervention/image@3.7.2...3.8.0

3.7.2

What's Changed

  • Add non-standard JPEG mimetype image/x-jpeg by @​dvlpp
  • Fix bug in encoding animated WEBP format by @​phknot

Full Changelog: Intervention/image@3.7.1...3.7.2

3.7.1

What's Changed

Full Changelog: Intervention/image@3.7.0...3.7.1

3.7.0

What's Changed

Full Changelog: Intervention/image@3.6.5...3.7.0

... (truncated)

Commits
  • b496d1f Add test assertions to validate the correct mime type
  • f712d68 Fix typo in mime type. (#1399)
  • 3618c8f Add .well-known directory to .gitattributes
  • d09d985 Add funding-manifest-urls
  • 1e0a2b6 Add MediaType::fileExtensions() & MediaType::fileExtension()
  • 20ad74e Add FileExtension::mediaType() & FileExtension::mediaTypes()
  • 57508a5 Add new method Format::fileExtension()
  • 4a5a7f6 Add method Format::mediaType()
  • cfa0986 Format phpunit config file
  • 8cf0405 Pass mime type manually to avoid finfo dependency
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 10, 2024
@dependabot dependabot bot requested review from dev-rminds and lexlog December 10, 2024 20:29
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 10, 2024

The following labels could not be found: Urgency: Low.

@lexlog
Copy link
Contributor

lexlog commented Dec 11, 2024

@dependabot rebase

Bumps [intervention/image](https://github.com/Intervention/image) from 2.7.2 to 3.9.1.
- [Release notes](https://github.com/Intervention/image/releases)
- [Commits](Intervention/image@2.7.2...3.9.1)

---
updated-dependencies:
- dependency-name: intervention/image
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/develop/intervention/image-3.9.1 branch from a84b1da to 0689503 Compare December 11, 2024 15:37
@dev-rminds
Copy link
Contributor

@RobinMeles @lexlog @irinaBerendeeva87 This is a big update with a lot of breaking changes, migration to the latest version is comparable with switching to a different library.

Therefore, there is a higher risk of something not working properly.
We need to test all media uploads to make sure everything is working as expected, for example:

  • Image quality is as expected (same as the before update)
  • Images cropped properly (aspect ratio is correct and image is cropped to the center)
  • small images are upscaled to the required size where needed

We already have some feature tests for medias (Tests\Feature\MediaUploadTest) but they don't cover the above points).
Maybe later we could add the last 2 points (cropping and upscaling) to the tests, the first one can only be done reliable manually.

@lexlog
Copy link
Contributor

lexlog commented Dec 13, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/composer/develop/intervention/image-3.9.1 branch 2 times, most recently from 7dadb11 to 1680e84 Compare December 13, 2024 10:17
@dev-rminds dev-rminds force-pushed the dependabot/composer/develop/intervention/image-3.9.1 branch from 1680e84 to 0019573 Compare December 13, 2024 10:30
Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked:

✅ Images cropped properly (aspect ratio is correct and image is cropped to the center)

✅ Small images are upscaled to the required size where needed

✅ no errors in the console

Out of PR test:

@irinaBerendeeva87 will create an issue (and also add other places optionally)

@lexlog lexlog added the Urgency: Low could be reviewed during multiple sprints label Dec 16, 2024
@lexlog lexlog merged commit a4f4416 into develop Dec 16, 2024
2 checks passed
@lexlog lexlog deleted the dependabot/composer/develop/intervention/image-3.9.1 branch December 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Urgency: Low could be reviewed during multiple sprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants