Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation exception in provider digest #2385

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Fix translation exception in provider digest #2385

merged 5 commits into from
Dec 16, 2024

Conversation

ateamcms
Copy link
Contributor

@ateamcms ateamcms commented Nov 7, 2024

Changes description

Developers checklist

  • Autotests are passed locally
  • Migration rollback works - if there is migration, check rollback
  • Autotests are added:
    • bugfix - unit/feature test for this scenario if possible
    • new small/medium feature - simple feature test for positive scenarios

QA checklist

  • Translations are done
  • Endpoint is fast on dump - if there is new endpoint or changed query, endpoints that are using changed query - working fast on production dump, <2s

@ateamcms ateamcms requested a review from dev-rminds November 7, 2024 20:50
@dev-rminds dev-rminds marked this pull request as ready for review November 8, 2024 10:39
@lexlog lexlog added the Urgency: Medium needs to be reviewed during sprint label Dec 10, 2024
irinaBerendeeva87
irinaBerendeeva87 requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked :
there are some errors on logs
log for forus.digest:provider_products.txt

@ateamcms ateamcms assigned dev-rminds and unassigned ateamcms Dec 11, 2024
irinaBerendeeva87
irinaBerendeeva87 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@irinaBerendeeva87 irinaBerendeeva87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked:

fixed:
✅ no errors

@lexlog lexlog merged commit e2bfe2a into develop Dec 16, 2024
2 checks passed
@lexlog lexlog deleted the fixes.translation-exception-in-provider-digest branch December 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinaBerendeeva87 irinaBerendeeva87 irinaBerendeeva87 approved these changes

@dev-rminds dev-rminds Awaiting requested review from dev-rminds

Assignees

@lexlog lexlog

Labels
Urgency: Medium needs to be reviewed during sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ateamcms @irinaBerendeeva87 @lexlog @dev-rminds