set datetimes via keystrokes based on detected locale in Selenium driver #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
force-pushed
the
detect_locale
branch
3 times, most recently
from
3d33446
to
2cb8acd
Compare
twalpole
force-pushed
the
detect_locale
branch
2 times, most recently
from
fb04799
to
7a5f214
Compare
twalpole
force-pushed
the
detect_locale
branch
from
7a5f214
to
216d308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hron Since you were working on something around setting of date/time entries previously could you take a look at this and see whether it gets your locale correctly and what format strings/lambdas would need to be added to LOCALE_KEYSTROKES for that locale? I would really like to get to a point where date/time inputs can be set via keystrokes in most cases.
Note: this is very preliminary code and will be refactored many times before it is (if ever) merged