Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node js to v23.6.1 #9500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1

default_image: &default_image
docker:
- image: cimg/node:23.5.0
- image: cimg/node:23.6.1

default_resource_class: &default_resource_class
resource_class: medium
Expand Down Expand Up @@ -87,7 +87,7 @@ commands: # reusable commands
default: 'BASE_IMAGE'
type: string
docker_build_arg_value:
default: 'node:23.5.0'
default: 'node:23.6.1'
type: string
image_name:
default: 'bitcli/bit'
Expand Down Expand Up @@ -116,7 +116,7 @@ commands: # reusable commands
default: 'BASE_IMAGE'
type: string
docker_build_arg_value:
default: 'node:23.5.0'
default: 'node:23.6.1'
type: string
image_name:
default: 'bitcli/bit'
Expand Down Expand Up @@ -198,13 +198,13 @@ commands: # reusable commands
windows_set_node_version:
parameters:
version:
default: 23.5.0
default: 23.6.1
type: string
steps:
- run: choco upgrade nvm -y
- run: nvm -v
- run: nvm install 23.5.0
- run: nvm use 23.5.0
- run: nvm install 23.6.1
- run: nvm use 23.6.1
- run: node -v
windows_add_bvm_to_path:
steps:
Expand Down Expand Up @@ -272,8 +272,8 @@ jobs:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_arg_value: "node:23.5.0"
docker_tag_suffix: "-node-23.5.0"
docker_build_arg_value: "node:23.6.1"
docker_tag_suffix: "-node-23.6.1"

# docker_non_root_build:
# machine:
Expand All @@ -292,10 +292,10 @@ jobs:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_arg_value: "node:23.5.0"
docker_build_arg_value: "node:23.6.1"
image_name: "bitcli/bit-non-root"
docker_file_name: "Dockerfile-bit-non-root"
docker_tag_suffix: "-node-23.5.0"
docker_tag_suffix: "-node-23.6.1"


server_docker_build_node_23:
Expand All @@ -306,10 +306,10 @@ jobs:
at: ./
- docker_build_and_push:
docker_build_arg_name: "BIT_IMAGE"
docker_build_arg_value: "`npm show @teambit/bit version`-node-23.5.0"
docker_build_arg_value: "`npm show @teambit/bit version`-node-23.6.1"
image_name: "bitcli/bit-server"
docker_file_name: "Dockerfile-bit-server"
docker_tag_suffix: "-node-23.5.0"
docker_tag_suffix: "-node-23.6.1"
set_ssh_key:
<<: *defaults
working_directory: ~/.ssh
Expand Down Expand Up @@ -913,9 +913,9 @@ jobs:
# - run: node -v
# - run: npm -v
# - run: yarn -v
# # - run: choco install nodejs --version 23.5.0
# # - run: choco install nodejs --version 23.6.1
# # - run: node -v
# - run: cinst nodejs --version 23.5.0
# - run: cinst nodejs --version 23.6.1
# - run: node -v

windows_checkout_code:
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-teambit-bit/Dockerfile-bit
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=node:23.5.0
ARG BASE_IMAGE=node:23.6.1
FROM $BASE_IMAGE
USER root

Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-teambit-bit/Dockerfile-bit-non-root
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=node:23.5.0
ARG BASE_IMAGE=node:23.6.1
FROM $BASE_IMAGE
RUN adduser --disabled-password --gecos '' user
RUN chown -R user /usr/local/
Expand Down
4 changes: 2 additions & 2 deletions workspace.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@
"encoding": "-"
},
"rootComponents": true,
"nodeVersion": "23.5.0",
"nodeVersion": "23.6.1",
"engineStrict": true,
// This is a temporary workaround to fix "bit compile" on macOS and Windows.
// "bit compile" breaks node_modules when hard links are used.
Expand Down Expand Up @@ -711,7 +711,7 @@
"packageJson": {
"name": "@teambit/{name}", // @teambit/discovery.ui.sidebar
"bvm": {
"node": "23.5.0"
"node": "23.6.1"
},
"bin": {
"bbit": "bin/bit"
Expand Down