Add __len metamethod to PackTable #1065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed both the table.pack definitions to return PackTable<T>
|
Teal Playground URL: https://1065--teal-playground-preview.netlify.app |
Member
|
This is interesting, but it does deviate from Lua semantics, right? I think a case could be made that we can get this at "zero-cost" in a compiled language, but I'm not sure we ever changed the behavior of Lua standard library functions in Teal apart from compat stuff. Curious to hear how people feel about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make using
#for the length of aPackTabledo the right thing.Also changed both the
table.packdefinitions to returnPackTable<T>.