CI: cache luarocks folder #1057
Conversation
As per actions/toolkit#658 (comment), overwriting a saved cache doesn't work and throws a warning.
|
Teal Playground URL: https://1057--teal-playground-preview.netlify.app |
|
That's awesome! I triggered the CI twice on your PR and it ran a lot faster! Thank you for this :) |
| luarocks lint tl-dev-1.rockspec | ||
| make selfbuild | ||
| luarocks test | ||
There was a problem hiding this comment.
This is quite a bit of hoopla and repeated code you don't need to do.
If you just use actions/cache@v4 instead of manually using the save and restore functions separately then you only need to have one uses: block (at the point where the restore would be) and a hook takes care of the save automatically. See here for an example in use:
https://github.com/alerque/polytype/blob/master/.github/workflows/deploy.yml#L27-L31
There was a problem hiding this comment.
Thanks for the review! I don't know how I missed that
How would I get a fix for this in? Another PR? @hishamhm
3 participants
Should fix #858.
I went for the whole folder instead of just Busted and it's dependencies because doing just Busted would've left me trying to reference multiple specific paths per platform and that felt way too messy. Hope that's ok.