Add docker build test on PR

.github/workflows/ci.yml

@@ -1,90 +1,87 @@
 name: CI
 
 on:
-  push:
-    paths-ignore:
-      - 'docker/**'
   pull_request:
     paths-ignore:
       - 'docker/**'
 
 env:
-    COMPOSER_ALLOW_SUPERUSER: '1'
-    SYMFONY_DEPRECATIONS_HELPER: max[self]=0
-    ADMIN_LOGIN: admin
-    ADMIN_PASSWORD: test
-    DATABASE_URL: mysql://user:password@mysql:3306/test_db
+  COMPOSER_ALLOW_SUPERUSER: '1'
+  SYMFONY_DEPRECATIONS_HELPER: max[self]=0
+  ADMIN_LOGIN: admin
+  ADMIN_PASSWORD: test
+  DATABASE_URL: mysql://user:password@mysql:3306/test_db
 
 jobs:
-    analyze:
-        name: Analyze
-        runs-on: ubuntu-latest
-        container:
-            image: php:8.2-alpine
-            options: >-
-              --tmpfs /tmp:exec
-              --tmpfs /var/tmp:exec
-        steps:
-            - name: Checkout
-              uses: actions/checkout@v3
-            - name: Install GD PHP extension
-              run: |
-                apk add $PHPIZE_DEPS libpng-dev
-                docker-php-ext-configure gd
-                docker-php-ext-install gd
-            - name: Install Composer
-              run: wget -qO - https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer --quiet
-            - name: Validate Composer
-              run: composer validate
-            - name: Update to highest dependencies with Composer
-              run: composer update --no-interaction --no-progress --ansi
-            - name: Analyze
-              run: PHP_CS_FIXER_IGNORE_ENV=True vendor/bin/php-cs-fixer fix --ansi
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    container:
+      image: php:8.2-alpine
+      options: >-
+        --tmpfs /tmp:exec
+        --tmpfs /var/tmp:exec
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Install GD PHP extension
+        run: |
+          apk add $PHPIZE_DEPS libpng-dev
+          docker-php-ext-configure gd
+          docker-php-ext-install gd
+      - name: Install Composer
+        run: wget -qO - https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer --quiet
+      - name: Validate Composer
+        run: composer validate
+      - name: Update to highest dependencies with Composer
+        run: composer update --no-interaction --no-progress --ansi
+      - name: Analyze
+        run: PHP_CS_FIXER_IGNORE_ENV=True vendor/bin/php-cs-fixer fix --ansi
 
-    phpunit:
-        name: PHPUnit (PHP ${{ matrix.php }})
-        runs-on: ubuntu-latest
-        container:
-            image: php:${{ matrix.php }}-alpine
-            options: >-
-              --tmpfs /tmp:exec
-              --tmpfs /var/tmp:exec
-        services:
-          mysql:
-            image: mariadb:10.7
-            env:
-              MYSQL_DATABASE: test_db
-              MYSQL_USER: user
-              MYSQL_PASSWORD: password
-              MYSQL_ROOT_PASSWORD: root
-            options: >-
-              --health-cmd "mysqladmin ping"
-              --health-interval 10s
-              --health-timeout 5s
-              --health-retries 5
-            ports:
-              - 3306:3306
-        strategy:
-            matrix:
-                php:
-                    - '8.0'
-                    - '8.1'
-                    - '8.2'
-            fail-fast: false
-        steps:
-            - name: Checkout
-              uses: actions/checkout@v3
-            - name: Install MySQL / GD PHP extensions
-              run: |
-                apk add $PHPIZE_DEPS icu-libs icu-dev libpng-dev
-                docker-php-ext-configure intl
-                docker-php-ext-configure gd
-                docker-php-ext-install pdo pdo_mysql intl gd
-            - name: Install Composer
-              run: wget -qO - https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer --quiet
-            - name: Install dependencies with Composer
-              run: composer install --no-progress --no-interaction --ansi
-            - name: Migrate database
-              run: bin/console doctrine:schema:update --force --no-interaction --complete
-            - name: Run tests with PHPUnit
-              run: vendor/bin/phpunit --process-isolation --colors=always
+  phpunit:
+    name: PHPUnit (PHP ${{ matrix.php }})
+    runs-on: ubuntu-latest
+    container:
+      image: php:${{ matrix.php }}-alpine
+      options: >-
+        --tmpfs /tmp:exec
+        --tmpfs /var/tmp:exec
+    services:
+      mysql:
+        image: mariadb:10.7
+        env:
+          MYSQL_DATABASE: test_db
+          MYSQL_USER: user
+          MYSQL_PASSWORD: password
+          MYSQL_ROOT_PASSWORD: root
+        options: >-
+          --health-cmd "mysqladmin ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 3306:3306
+    strategy:
+      matrix:
+        php:
+          - '8.0'
+          - '8.1'
+          - '8.2'
+      fail-fast: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Install MySQL / GD PHP extensions
+        run: |
+          apk add $PHPIZE_DEPS icu-libs icu-dev libpng-dev
+          docker-php-ext-configure intl
+          docker-php-ext-configure gd
+          docker-php-ext-install pdo pdo_mysql intl gd
+      - name: Install Composer
+        run: wget -qO - https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer --quiet
+      - name: Install dependencies with Composer
+        run: composer install --no-progress --no-interaction --ansi
+      - name: Migrate database
+        run: bin/console doctrine:schema:update --force --no-interaction --complete
+      - name: Run tests with PHPUnit
+        run: vendor/bin/phpunit --process-isolation --colors=always

.github/workflows/main.yml

@@ -2,146 +2,94 @@ name: Publish Docker image
 
 on:
   workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - main
+      - renovate/**
   release:
-    types: [published]
+    types: [ published ]
 
 env:
-  # Use docker.io for Docker Hub if empty
   REGISTRY: ghcr.io
-  # github.repository as <account>/<repo>
-  IMAGE_NAME: ${{ github.repository }}
+  IMAGE_NAME: ${{ github.repository }}  # <organization>/<repository>
+  BUILD_ARCHITECTURES: linux/amd64,linux/arm64
 
 jobs:
-  build:
+  build-image:
     name: Build Docker images
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        platform:
-          - linux/amd64
-          - linux/arm64
     steps:
-      -
-        name: Prepare
-        run: |
-          platform=${{ matrix.platform }}
-          echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV 
-      -
-        name: Checkout
-        uses: actions/checkout@v4
-      - 
-        name: Extract metadata
+      - uses: actions/checkout@v4
+      - uses: docker/setup-qemu-action@v3
+      - uses: docker/setup-buildx-action@v3
+      - uses: docker/build-push-action@v5
+        with:
+          push: false
+          platforms: ${{ env.BUILD_ARCHITECTURES }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
+  push-to-edge:
+    name: Build Docker images
+    runs-on: ubuntu-latest
+    needs: [ build-image ]
+    if: ${{ github.ref_name == github.event.repository.default_branch }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: docker/setup-qemu-action@v3
+      - uses: docker/setup-buildx-action@v3
+      - uses: docker/login-action@v3
+        with:
+          registry: ${{ env.REGISTRY }}
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.token }}
+      - uses: docker/metadata-action@v5
         id: meta
-        uses: docker/metadata-action@v5
         with:
           context: git
           images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
-          # "Push by digest" needs an untagged ref
           tags: |
-            type=raw,value=
-      -
-        name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-      -
-        name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-        with:
-          version: v0.12.0
-        env:
-          BUILDX_NO_DEFAULT_ATTESTATIONS: 1
-      -
-        name: Login to GitHub Container Registry (${{ env.REGISTRY }})
-        uses: docker/login-action@v3
-        with:
-          registry: ${{ env.REGISTRY }}
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-      -
-        name: Build and Push by digest
-        id: build
-        uses: docker/build-push-action@v5
+            type=edge,branch=${{ github.ref_name }}
+      - uses: docker/build-push-action@v5
         with:
-          context: .
-          file: docker/Dockerfile
-          platforms: ${{ matrix.platform }}
-          tags: ${{ steps.meta.outputs.tags }}
-          labels: ${{ steps.meta.outputs.labels }}
+          push: true
+          platforms: ${{ env.BUILD_ARCHITECTURES }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
           annotations: ${{ steps.meta.outputs.annotations }}
-          outputs: type=image,name=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }},push-by-digest=true,name-canonical=true,push=true
-      -
-        name: Export digest
-        run: |
-          mkdir -p /tmp/digests
-          digest="${{ steps.build.outputs.digest }}"
-          touch "/tmp/digests/${digest#sha256:}"          
-      -
-        name: Upload digest
-        uses: actions/upload-artifact@v4
-        with:
-          name: digests-${{ env.PLATFORM_PAIR }}
-          path: /tmp/digests/*
-          if-no-files-found: error
-          retention-days: 1
+          labels: ${{ steps.meta.outputs.labels }}
+          tags: ${{ steps.meta.outputs.tags }}
+      - run: |
+          docker buildx imagetools inspect ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:edge
 
-  merge:
-    name: Create merged manifest and push to Github Packages
+  push-to-version:
+    name: Build Docker images
     runs-on: ubuntu-latest
-    needs:
-      - build
+    needs: [ build-image ]
+    if: ${{ github.event_name == 'release' }}
     steps:
-      -
-        # Needed to get the git information for the meta step
-        name: Checkout
-        uses: actions/checkout@v4
-      -
-        name: Download digests
-        uses: actions/download-artifact@v4
-        with:
-          path: /tmp/digests
-          pattern: digests-*
-          merge-multiple: true
-      -
-        name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+      - uses: actions/checkout@v4
+      - uses: docker/setup-qemu-action@v3
+      - uses: docker/setup-buildx-action@v3
+      - uses: docker/login-action@v3
         with:
-          version: v0.12.0
-        env:
-          BUILDX_NO_DEFAULT_ATTESTATIONS: 1
-      -
-        # Extract metadata to easily get the version and annotations to put in the manifest
-        name: Docker meta
+          registry: ${{ env.REGISTRY }}
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.token }}
+      - uses: docker/metadata-action@v5
         id: meta
-        uses: docker/metadata-action@v5
         with:
           context: git
           images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
-          tags: |
-            type=semver,pattern={{version}}
-            type=edge,branch=${{ github.ref_name }}
-      -
-        name: Login to Docker Hub
-        uses: docker/login-action@v3
+      - uses: docker/build-push-action@v5
         with:
-          registry: ${{ env.REGISTRY }}
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-      -
-        name: Create manifest list and push
-        working-directory: /tmp/digests
-        run: |
-          docker buildx imagetools create \
-            $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
-            --annotation index:org.opencontainers.image.created="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.created'] }}" \
-            --annotation index:org.opencontainers.image.description="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.description'] }}" \
-            --annotation index:org.opencontainers.image.version="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.version'] }}" \
-            --annotation index:org.opencontainers.image.licenses="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.licenses'] }}" \
-            --annotation index:org.opencontainers.image.title="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.title'] }}" \
-            --annotation index:org.opencontainers.image.source="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.source'] }}" \
-            --annotation index:org.opencontainers.image.url="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.url'] }}" \
-            --annotation index:org.opencontainers.image.revision="${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.revision'] }}" \
-            $(printf '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}@sha256:%s ' *)          
-      -
-        name: Inspect image
-        run: |
-          docker buildx imagetools inspect ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.meta.outputs.version }}          
+          push: true
+          platforms: ${{ env.BUILD_ARCHITECTURES }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+          annotations: ${{ steps.meta.outputs.annotations }}
+          labels: ${{ steps.meta.outputs.labels }}
+          tags: ${{ steps.meta.outputs.tags }}
+      - run: |
+          docker buildx imagetools inspect ${{ env.REGISTRY }}/${{ env.GITHUB_REF_NAME }}:

docker/Dockerfile → Dockerfile

@@ -88,10 +88,6 @@ FROM base-image
 ARG fpm_user=82:82
 ENV FPM_USER=${fpm_user}
 
-LABEL org.opencontainers.image.authors="[email protected]"
-LABEL org.opencontainers.image.url="https://github.com/tchapi/davis/pkgs/container/davis-standalone"
-LABEL org.opencontainers.image.description="A simple, fully translatable admin interface for sabre/dav based on Symfony 5 and Bootstrap 4 (Standalone version with reverse-proxy)"
-
 COPY --from=extension-builder /usr/local/etc/php/conf.d     /usr/local/etc/php/conf.d/
 COPY --from=extension-builder /usr/local/lib/php/extensions /usr/local/lib/php/extensions/
 COPY --from=composer          /var/www/davis/vendor         /var/www/davis/vendor/