Temporal: Add test for balancing up to weeks when year/month are present #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested changes
Nov 7, 2024
| @@ -0,0 +1,52 @@ | |||
| // Copyright (C) 2018 Bloomberg LP. All rights reserved. | |||
There was a problem hiding this comment.
New test, so
Suggested change
| // Copyright (C) 2018 Bloomberg LP. All rights reserved. | |
| // Copyright (C) 2024 Igalia, S.L. All rights reserved. |
|
|
||
| /*--- | ||
| esid: sec-temporal.duration.prototype.round | ||
| description: Balances up to weeks correctly when years and months are present. |
There was a problem hiding this comment.
Nitpick about the terminology:
Suggested change
| description: Balances up to weeks correctly when years and months are present. | |
| description: Rounds up to weeks correctly when years and months are present. |
I'd suggest renaming the test file as well.
(Rounding is when the duration is modified, balancing is when the duration remains the same length but is expressed in different units)
| ---*/ | ||
|
|
||
| const oneMonthOneDay = new Temporal.Duration(0, 1, 0, 1, 0, 0, 0, 0, 0, 0); | ||
| const oneYearOneMonthOneDay = new Temporal.Duration(1, 1, 0, 1, 0, 0, 0, 0, 0, 0); |
There was a problem hiding this comment.
I'd suggest something like
const relativeTo = new Temporal.PlainDate(2024, 1, 1);and using that in the options bags throughout.
There was a problem hiding this comment.
Also, I've been looking at the existing tests in round/ and I think we might not have coverage of rounding a duration with only days up to weeks. So maybe add something like
const severalWeeksInDays = new Temporal.Duration(0, 0, 0, 29, 0, 0, 0, 0, 0, 0);(I might have missed it if we already had coverage of this, though! There are a lot of tests in this folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-temporal#2813