Temporal: Move tests out of staging/Temporal/Regex/old and into test/built-ins #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
changed the title
ptomato
reviewed
Oct 30, 2024
There was a problem hiding this comment.
I think I want to put this one on hold until I've worked through all the other open PRs. Looking over it now, I noticed some weirdness with strings that seem like they shouldn't parse correctly, so I'm not certain these tests are correct in the first place. That probably needs some digging into.
We also might want to expand it to cover all entry points that parse strings, not just from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move each of these tests into the appropriate subdirectory of
test/built-ins/Temporal.