-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different approximations in the observational Islamic calendar #4101
base: main
Are you sure you want to change the base?
Conversation
The "islamic" calendar id refers to the observational Islamic calendar and different implementation may use different algorithms to approximate when the moon's crescent can be observed. Change the test data to allow the approximations used in ICU4X in addition to the ones used in ICU4C.
ae4cb32
to
b98456b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
How soon would it be possible to determine whether ICU4C or ICU4X's calculation is correct? I mean, this is a date in the past, so there should be one correct answer to the question "what was the Gregorian date on 1 Muharram 1445?" for each one of the supported astronomical Islamic calendars. In other words, when results from ICU4C and ICU4X differ for dates that have already happened, at least one of them is objectively wrong. If it's not feasible in the short term to determine which is correct, then sure, we could adopt this as a temporary measure to avoid cluttering test failure results with something that is not directly relevant to whether ECMA-402 is implemented correctly. I wouldn't want to keep it permanently though. |
This is possibly caused by unicode-org/icu4x#4982. From https://en.wikipedia.org/wiki/Hijrah#Aftermath_and_legacy:
Which is an excerpt from https://archive.org/details/elementsofjewish00burnuoft. Part II, Chapter 1.6, starting on p. 371 has more details: https://archive.org/details/elementsofjewish00burnuoft/elementsofjewish00burnuoft/page/370/mode/2up |
Subscribed to that issue, thanks. |
The "islamic" calendar id refers to the observational Islamic calendar and different implementation may use different algorithms to approximate when the moon's crescent can be observed. Change the test data to allow the approximations used in ICU4X in addition to the ones used in ICU4C.
Additionally allow implementations to canonicalise the calendar id.