-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ChakraCore CI job #4040
Remove ChakraCore CI job #4040
Conversation
Installation of ChakraCore by ESVU for some reason has been flaky for quite a long time. Can't reproduce locally. This CI job doesn't add much value by itself, so just remove it until some future time. Closes: tc39#3953
5c6293b
to
df77942
Compare
Should we notify chakracore's maintainers? |
Not sure whether it's an ESVU problem or a ChakraCore problem. (Although I see ESVU is removing ChakraCore in the next release) |
Seems to be a known problem for which a PR has been open for 9 months: chakra-core/ChakraCore#6932 |
cc @rhuanjl on both issues. |
Thanks for the tag; @ljharb I'll aim to merge a fix for the mentioned issue in CC; it's sad to see CC support being dropped in other places, though as is probably obviously, CC is largely a dead project these days. I don't have nearly the time/scope to maintain it properly alone (I have a completely unrelated - not-programming - full time job) and I'm not aware of anyone with enough time who has the knowledge/interest. I'd love to help CC be revived and used again if there is ever significant interest from others willing to throw some significant time at it, please do continue to tag me if/when anything relevant to CC is said or done. |
FYI I think we've fixed the CC crash you were encountering - a couple of us are going to try and do a bit more work on CC. |
@rhuanjl ESVU removed ChakraCore support and that's what we use to install the interpreters used for CI... I think the next step would be to get it re-added there. I'll open an issue and tag you. |
Installation of ChakraCore by ESVU for some reason has been flaky for quite a long time. Can't reproduce locally. This CI job doesn't add much value by itself, so just remove it until some future time.
Closes: #3953