Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Define ILD and ILND in exactly one place (4.4) #924

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ben-allen
Copy link
Contributor

Previously ILD acronym had been defined in several different places, likewise ILND. New version defines these exactly once, in 4.4. Implementation Dependencies

Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There are also some phrases to replace in spec/datetimeformat.html and spec/numberformat.html:

  • 1. Let _fv_ be an implementation and locale dependent String value representing *"post meridiem"*.
    1. Else,
    1. Let _fv_ be an implementation and locale dependent String value representing *"ante meridiem"*.
    1. Append the Record { [[Type]]: *"dayPeriod"*, [[Value]]: _fv_ } to _result_.
    1. Else if _p_ is *"relatedYear"*, then
    1. Let _v_ be _tm_.[[RelatedYear]].
    1. Let _fv_ be FormatNumeric(_nf_, _v_).
    1. Append the Record { [[Type]]: *"relatedYear"*, [[Value]]: _fv_ } to _result_.
    1. Else if _p_ is *"yearName"*, then
    1. Let _v_ be _tm_.[[YearName]].
    1. Let _fv_ be an implementation and locale dependent String value representing _v_.
  • <li>[[Notation]] is one of the String values *"standard"*, *"scientific"*, *"engineering"*, or *"compact"*, specifying whether the formatted number should be displayed without scaling, scaled to the units place with the power of ten in scientific notation, scaled to the nearest thousand with the power of ten in scientific notation, or scaled to the nearest locale-dependent compact decimal notation power of ten with the corresponding compact decimal notation affix.</li>

spec/overview.html Outdated Show resolved Hide resolved
…suggestions re: additional spec lines that needed to be reworded to use ILD/ILND initialisms.
@ben-allen
Copy link
Contributor Author

@gibson042 updated based on your suggestions!

@ben-allen ben-allen marked this pull request as ready for review September 26, 2024 14:14
@gibson042 gibson042 merged commit 3830eac into tc39:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants