Normative: Allow use of non-ISO 4217 data in CurrencyDigits AO
#922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows for locale data other than ISO 4217 for determining the number of fractional digits to be used when formatting currency values. In some applications ISO 4217 is most appropriate, in some CLDR data, and in some neither is best. See tc39#921 (comment) Resolves tc39#134 This PR makes the `CurrencyDigits` AO implementation-defined.
ben-allen
force-pushed
the
currency-digits-ild
branch
from
ce771ee
to
c8aa18e
Compare
gibson042
approved these changes
Sep 12, 2024
Co-authored-by: Richard Gibson <[email protected]>
|
@sffc said: "This PR looks good except I would like to have verification that CLDR does not actually try to match ISO 4217." |
|
CLDR spec change: unicode-org/cldr#4112 |
|
I believe this PR is discussed in TC39 2024-10-09 meeting and reach consensus |
|
Received consensus at October 2024 plenary, with guidance to make future editorial changes giving recommended data source |
ben-allen
added
needs tests
has consensus (TG1)
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 29, 2024
treats ISO 4217 data on the number of minor unit digits to use when formatting currencies. See tc39/ecma402#922
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 29, 2024
…for currency minor unit digits ISO 4217 no longer normative for currency minor digits. New test verifies that currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits` are identical. See tc39/ecma402#922
ptomato
pushed a commit
to ben-allen/test262
that referenced
this pull request
Oct 31, 2024
…for currency minor unit digits ISO 4217 no longer normative for currency minor digits. New test verifies that currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits` are identical. See tc39/ecma402#922
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Oct 31, 2024
ISO 4217 no longer normative for currency minor digits. New test verifies that currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits` are identical. See tc39/ecma402#922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for locale data other than ISO 4217 for determining the number of fractional digits to be used when formatting currency values.
In some applications ISO 4217 is most appropriate, in some CLDR data, and in some neither is best. See #921 (comment)
Resolves #134
This PR makes the
CurrencyDigitsAO implementation-defined.