Editorial: Add GetLocaleBaseName abstract operation #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `GetLocaleBaseName` to avoid repeating the same steps to extract the `unicode_language_id` parts of a `unicode_locale_id`. The abstract operation is named to `GetLocaleBaseName` to match the accessor property `Intl.Locale.prototype.baseName`.
anba
commented
Aug 5, 2024
| 1. If _variants_ is not *undefined*, set _newLanguageId_ to the string-concatenation of _newLanguageId_, *"-"*, and _variants_. | ||
| 1. Let _newTag_ be _tag_ with the <emu-not-ref>substring</emu-not-ref> matched by the <code>unicode_language_id</code> Unicode locale nonterminal replaced by the string _newLanguageId_. | ||
| 1. Let _variants_ be GetLocaleVariants(_baseName_). | ||
| 1. Let _allExtensions_ be the suffix of _tag_ following _baseName_. |
There was a problem hiding this comment.
Taking the suffix string matches the approach taken in IsStructurallyValidLanguageTag. This also let's us avoid having to reference unicode_language_id below and we can instead use simple string concatenation.
ben-allen
reviewed
Aug 14, 2024
ben-allen
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GetLocaleBaseNameto avoid repeating the same steps to extract theunicode_language_idparts of aunicode_locale_id. The abstract operation is named toGetLocaleBaseNameto match the accessor propertyIntl.Locale.prototype.baseName.