Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: replaced ≥ ∞ « “ ≤ — ≠ &r… #907

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ben-allen
Copy link
Contributor

#634 observed that ECMA-262 had standardized on using HTML character entities rather than non-ASCII characters such as ≤ and ≥. However, in the time since that issue was raised 262 re-standardized on directly using the Unicode characters rather than using HTML entities.

This PR replaces the relevant HTML character entities with the Unicode characters they represent.

@ben-allen ben-allen requested review from gibson042 and ryzokuken July 18, 2024 13:58
@ben-allen ben-allen added the editorial Involves an editorial fix label Jul 18, 2024
ptomato added a commit to tc39/proposal-temporal that referenced this pull request Jul 24, 2024
@ben-allen
Copy link
Contributor Author

Could I get a quick review of this one? It's been sitting for a minute. @gibson042 @ryzokuken

ptomato added a commit to tc39/proposal-temporal that referenced this pull request Aug 8, 2024
@ben-allen ben-allen force-pushed the remove-html-entities branch from 1b5126b to 155e000 Compare August 14, 2024 17:02
…aquo; ” ×

with their corresponding non-ascii characters
@ben-allen ben-allen force-pushed the remove-html-entities branch from d1e3dc0 to d7e2853 Compare August 14, 2024 17:08
@ben-allen
Copy link
Contributor Author

@gibson042 quick review? Mostly I want to make sure that my interpretation of 262's standard for html entities is correct.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a similar change in the Temporal proposal recently, this looks correct.

@ben-allen ben-allen merged commit a31417a into tc39:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Involves an editorial fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants