fix(deps): depend on kondo-lib 0.9 from the workspace #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ah nuts, yea kondo-ui is a bit neglected tbh, I didn't update it to 0.9 along with the others and it's in the workspace exclude. Thanks for catching that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this command fails:
$ cargo fetch --manifest-path kondo-ui/Cargo.toml Updating crates.io index error: failed to select a version for the requirement `kondo-lib = "^0.8"` candidate versions found which didn't match: 0.9.0 location searched: /build/kondo/src/kondo-0.9/kondo-lib required by package `kondo-ui v0.8.0 (/build/kondo/src/kondo-0.9/kondo-ui)`It's because kondo-ui v0.8 depends on kondo-lib v0.8, but only kondo-lib v0.9 is available from the workspace.
This PR fixes that by depending on the latest version of kondo-lib.