Remove an optimisation which breaks relative URLs #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimisation disables relative paths when the output path is longer
than the input path - but the result of that is that the generated CSS
ends up pointing to URLs that are relative to the current directory
instead of being relative to the generated CSS file.
input: test-in/style.css
```
.foo { background-image: url("./local.png"); }
```
output: test-out/style.css
```
.foo { background-image: url("../test-in/local.png"); }
```
output: test-out/nested/path/style.css
```
.foo { background-image: url("test-in/local.png"); }
```
Author
|
(bulk-closing PRs for libraries I'm no longer using) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimisation disables relative paths when the output path is longer than the input path - but the result of that is that the generated CSS ends up pointing to URLs that are relative to the current directory instead of being relative to the generated CSS file.
input: test-in/style.css
When writing to an output directory which is less than or equal to the depth of the input, the path to the file is relative to the output .css
output: test-out/style.css
When writing to an output directory which is deeper than the input, relativity is disabled, and the path is broken
output: test-out/nested/path/style.css