-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt5 migration #40
base: Python3/Qt5-build
Are you sure you want to change the base?
Qt5 migration #40
Conversation
Thanks for taking the time to look into this. From a quick overview it looks like for the most part I just need to change a few lines for imports, along with a few syntax changes that should be cross compatible with Python 2.7. |
It doesn't work for me :(
|
In stylus.py:584 the command "xsetwacom --get %s area" should be called with 'text=True' attribute. In python3 popen will return you bytes instead of a string and that will break a bunch of things (like saving to json, or calling 'split' with a charater instead of a byte sequence (https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess.stdout). In wacom-gui.py:505 there is a division by 4. It will return float by default. So it's better to convert to int straight away: In hotkeys.py:209 there is a filter statement. It produces a generator which is consumed by next line and therefore the cycle below does nothing. So the filter() may be replaced with |
This runs with Python3 and PyQt5 now.
I'm not a Python dev and I'm not familiar with Qt, so it's probably not "correct", but it works for me™