Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add transparent padding to macos icon #11037

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented Sep 17, 2024

opening as a draft cause idk whether it should be enabled by default and/or how to name the cli flag

edit: also the code may be a bit ugly still, i pushed once it was working to test it on my macbook

Copy link
Contributor

Package Changes Through 695f4ff

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@thewh1teagle
Copy link
Contributor

Hey
What's the status of the feature?
Can we add it? Or at least a flag to enable?
Thanks

@FabianLars
Copy link
Member Author

still the same as in my initial comment. idk if it should be default and how the cli flag should look like 🤷

@gaomd
Copy link

gaomd commented Feb 2, 2025

Can we get this merged?

macOS icon requires special treatment because as per Apple's guideline and icon templates, the actual content area of the macOS icon is the 824px * 824px out of the 1024px * 1024px. So when we only have 1 single icon, the tauri icon cli should automatically add the transparent padding around the icon to ensure consistency with other macOS icons.

EDIT: however the fix in the PR seems only adding the transparent padding so the icon size looks consistent with other macOS apps, but does not add shadow which is an essential part of the macOS icons, hence making the solution less optimal. Another approach might be to add an CLI option to allow specifying the macOS-only icon and only generate src-tauri/icons/icon.icns, and document macOS icon specs in the Tauri docs.

Screenshot 2025-02-03 at 00 26 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants