Form validation errors (#39)

* add auto_apply to coupon validation

* PHP Linting (Pint) - Fix styling

* add coupon test for coupon request

---------

Co-authored-by: obinnaelviso <[email protected]>

src/Requests/CouponRequest.php

@@ -55,6 +55,7 @@ public function rules()
             'recurring_to_time' => ['nullable', 'required_if:validity,recurring', 'valid_time'],
             'order_restriction.*' => ['nullable', 'string'],
             'status' => ['boolean'],
+            'auto_apply' => ['boolean'],
             'locations.*' => ['integer'],
         ];
     }

tests/Requests/CouponTest.php

@@ -0,0 +1,137 @@
+<?php
+
+namespace Tests\Requests;
+
+use Igniter\Coupons\Requests\CouponRequest;
+use Illuminate\Validation\Rule;
+
+it('has required rule for inputs:
+    name, code, type, discount, customer_redemptions, redemptions and validity',
+    function () {
+        $rules = (new CouponRequest)->rules();
+        $inputNames = ['name', 'code', 'type', 'discount', 'customer_redemptions', 'redemptions', 'validity'];
+        $testExpectation = null;
+
+        foreach ($inputNames as $key => $inputName) {
+            if ($key == 0) {
+                $testExpectation = expect('required')->toBeIn(array_get($rules, $inputName));
+            }
+            $testExpectation = $testExpectation->and('required')->toBeIn(array_get($rules, $inputName));
+        }
+
+    }
+);
+
+it(
+    'has nullable rule for inputs: fixed_date, fixed_from_time, fixed_to_time, period_start_date,
+    period_end_date, recurring_every, recurring_from_time, recurring_to_time, order_restriction.*',
+    function () {
+        $rules = (new CouponRequest)->rules();
+        $inputNames = ['fixed_date', 'fixed_from_time', 'fixed_to_time', 'period_start_date', 'period_end_date',
+            'recurring_every', 'recurring_from_time', 'recurring_to_time', 'order_restriction.*'];
+        $testExpectation = null;
+        foreach ($inputNames as $key => $inputName) {
+            if ($key == 0) {
+                $testExpectation = expect('nullable')->toBeIn(array_get($rules, $inputName));
+            }
+            $testExpectation = $testExpectation->and('nullable')->toBeIn(array_get($rules, $inputName));
+        }
+
+    }
+);
+
+it('has string rule for inputs: type and order_restriction.*', function () {
+    $rules = (new CouponRequest)->rules();
+    $inputNames = ['type', 'order_restriction.*'];
+    $testExpectation = null;
+
+    foreach ($inputNames as $key => $inputName) {
+        if ($key == 0) {
+            $testExpectation = expect('string')->toBeIn(array_get($rules, $inputName));
+        }
+        $testExpectation = $testExpectation->and('string')->toBeIn(array_get($rules, $inputName));
+    }
+});
+
+it('has numeric rule for inputs: discount and min_total', function () {
+    $rules = (new CouponRequest)->rules();
+    $inputNames = ['discount', 'min_total'];
+    $testExpectation = null;
+
+    foreach ($inputNames as $key => $inputName) {
+        if ($key == 0) {
+            $testExpectation = expect('numeric')->toBeIn(array_get($rules, $inputName));
+        }
+        $testExpectation = $testExpectation->and('numeric')->toBeIn(array_get($rules, $inputName));
+    }
+});
+
+it('has integer rule for inputs: redemptions, customer_redemptions and locations.*', function () {
+    $rules = (new CouponRequest)->rules();
+    $inputNames = ['redemptions', 'customer_redemptions', 'locations.*'];
+    $testExpectation = null;
+
+    foreach ($inputNames as $key => $inputName) {
+        if ($key == 0) {
+            $testExpectation = expect('integer')->toBeIn(array_get($rules, $inputName));
+        }
+        $testExpectation = $testExpectation->and('integer')->toBeIn(array_get($rules, $inputName));
+    }
+});
+
+it('has boolean rule for inputs: status and auto_apply', function () {
+    $rules = (new CouponRequest)->rules();
+    $inputNames = ['status', 'auto_apply'];
+    $testExpectation = null;
+
+    foreach ($inputNames as $key => $inputName) {
+        if ($key == 0) {
+            $testExpectation = expect('boolean')->toBeIn(array_get($rules, $inputName));
+        }
+        $testExpectation = $testExpectation->and('boolean')->toBeIn(array_get($rules, $inputName));
+    }
+});
+it('has unique rule for code input', function () {
+    expect((string)(Rule::unique('igniter_coupons')->ignore(null, 'coupon_id')))
+        ->toBeIn(
+            collect(array_get((new CouponRequest)->rules(), 'code'))->map(function ($rule) {
+                return (string)$rule;
+            })->toArray()
+        );
+});
+
+it('has minimum of 2 chars rule for code input', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('min:2')->toBeIn(array_get($rules, 'code'));
+});
+
+it('has number of characters between 2 and 128 rule for name input', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('between:2,128')->toBeIn(array_get($rules, 'name'));
+});
+
+it('has number of 1 size rule for type input', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('size:1')->toBeIn(array_get($rules, 'type'));
+});
+
+it('has in:P,F rule for type input', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('in:P,F')->toBeIn(array_get($rules, 'type'));
+});
+
+it('has in:forever,fixed,period,recurring rule for validity input', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('in:forever,fixed,period,recurring')->toBeIn(array_get($rules, 'validity'));
+});
+
+it('has a maximum of 1028 characters for description rule', function () {
+    $rules = (new CouponRequest)->rules();
+
+    expect('max:1028')->toBeIn(array_get($rules, 'description'));
+});