Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Add pwa-starter-kit-hn #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keanulee
Copy link

Demo: https://pwa-starter-kit-hn.appspot.com/

App built with the same structure as PWA Starter Kit. More details in the commit.

@kristoferbaxter
Copy link
Collaborator

Hmm. Something is a bit off with the results here.

screen shot 2018-07-25 at 11 08 42 am

https://www.webpagetest.org/video/compare.php?tests=180725_WY_629a9c47602a77d93114d23463cd5ffc-r:1-c:0

When looking at the trace, it's clear the content is not present until ~4.1s, and the app appears to become interactive at ~3.8s. However, Lighthouse is marking the TTI at ~2.1s.

@keanulee
Copy link
Author

keanulee commented Aug 1, 2018

There seems to be some discrepancy between the WPT timeline and Lighthouse numbers. I posted the Lighthouse numbers since that's what the other demos use. @addyosmani do you have any ideas?

@housseindjirdeh
Copy link
Collaborator

housseindjirdeh commented Aug 2, 2018

@keanulee Aside from that, the app works well and LGTM 🚀 (the favorites tab is a nice touch!)

Running traces on a few other apps and I'm noticing similar discrepancies. I still need to update all the numbers on the site to 3.0 so I'll check in with someone from the team about this before I do so

CC @addyosmani @pmeenan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants