Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Custom Textfield (RN v0.68) #4

Open
wants to merge 18 commits into
base: 0.68-stable
Choose a base branch
from
Open

feat: Add Custom Textfield (RN v0.68) #4

wants to merge 18 commits into from

Conversation

alphatrl
Copy link
Collaborator

@alphatrl alphatrl commented Oct 17, 2022 •
edited
Loading

Custom Textfield v1

React Native: v0.68.6

Features/Modifications:

  1. New editorInput props, for modified version of textinput
  2. Return key will not make new line
  3. Underline highlight
  4. Gapless underline taken from here

iOS Build

No additional steps needed

Android Build

Build AAR with docker reactnativecommunity/react-native-android with tag 5

  • Note: tag5 drops JDK 8, and uses JDK 11

docker run --rm --name rn-build -v $PWD:/pwd -w /pwd reactnativecommunity/react-native-android:5 /bin/sh -c "./gradlew installArchives"

Commit:

# create .aar, then:
git add android --force
git commit -m 'my release commit'
git push

From Building from source

@alphatrl alphatrl force-pushed the taskade/release/0.68 branch 2 times, most recently from 8858a50 to d7d157b Compare October 17, 2022 09:29
@alphatrl alphatrl force-pushed the taskade/release/0.68 branch from 870f1ac to c7d6a8e Compare November 16, 2022 07:19
@alphatrl alphatrl force-pushed the taskade/release/0.68 branch from f1e36b3 to b015205 Compare February 23, 2023 08:29
@elliscwc elliscwc force-pushed the taskade/release/0.68 branch from 635293e to b015205 Compare March 29, 2023 08:01
fortmarek and others added 18 commits April 25, 2023 17:24
@fortmarek @kelset
Fix test e2e script (facebook#37081)
87611d4
@NickGerleman @kelset
Fix measurement of uncontrolled TextInput after edit
ccb9366 
Summary:
D42721684 (facebook@be69c8b) left a pretty bad bug when using Fabric for Android. I missed that in Fabric specifically, on edit we will cache the Spannable backing the EditText for use in future measurement.

Because we've stripped the sizing spans, Spannable measurement has incorrect font size, and the TextInput size will change (collapsing) after the first edit. This effectively breaks any uncontrolled TextInput which does not have explicit dimensions set.

Changelog:
[Android][Fixed] - Fix measurement of uncontrolled TextInput after edit

Reviewed By: sammy-SC

Differential Revision: D43158407

fbshipit-source-id: 51602eab06c9a50e2b60ef0ed87bdb4df025e51e
@NickGerleman @kelset
Minimize EditText Spans 1/9: Fix precedence (facebook#36543)
11755c1 
Summary:
Pull Request resolved: facebook#36543

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

We cache the backing EditText span on text change to later measure. To measure outside of a TextInput we need to restore any spans we removed. Spans may overlap, so base attributes should be behind everything else.

The logic here for dealing with precedence is incorrect, and we should instead accomplish this by twiddling with the `SPAN_PRIORITY` bits.

Changelog:
[Android][Fixed] - Minimize Spans 1/N: Fix precedence

Reviewed By: javache

Differential Revision: D44240779

fbshipit-source-id: f731b353587888faad946b8cf1e868095cdeced3
@NickGerleman @kelset
Minimize EditText Spans 2/9: Make stripAttributeEquivalentSpans gener…
485b8ef 
…ic (facebook#36546)

Summary:
Pull Request resolved: facebook#36546

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This change generalizes `stripAttributeEquivalentSpans()` to allow plugging in different spans.

Changelog:
[Internal]

Reviewed By: rshest

Differential Revision: D44240781

fbshipit-source-id: 89005266020f216368e9ad9ce382699bd8db85a8

# Conflicts:
#	ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java
@NickGerleman @kelset
Minimize EditText Spans 3/9: ReactBackgroundColorSpan (facebook#36547)
3cdcbe7 
Summary:
Pull Request resolved: facebook#36547

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This adds `ReactBackgroundColorSpan` to the list of spans eligible to be stripped.

Changelog:
[Android][Fixed] - Minimize Spans 3/N: ReactBackgroundColorSpan

Reviewed By: javache

Differential Revision: D44240782

fbshipit-source-id: 2ded1a1687a41cf6d5f83e89ffadd2d932089969
@NickGerleman @kelset
Minimize EditText Spans 4/9: ReactForegroundColorSpan (facebook#36545)
b164055 
Summary:
Pull Request resolved: facebook#36545

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This adds ReactForegroundColorSpan to the list of spans eligible to be stripped.

Changelog:
[Android][Fixed] - Minimize Spans 4/N: ReactForegroundColorSpan

Reviewed By: javache

Differential Revision: D44240780

fbshipit-source-id: d86939cc2d7ed9116a4167026c7d48928fc51757
@NickGerleman @kelset
Minimize EditText Spans 5/9: Strikethrough and Underline (facebook#36544
54cc78a 
)

Summary:
Pull Request resolved: facebook#36544

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This change makes us apply strikethrough and underline as paint flags to the underlying EditText, instead of just the spans. We then opt ReactUnderlineSpan and ReactStrikethroughSpan into being strippable.

This does actually create visual behavior changes, where child text will inherit any underline or strikethrough of the root EditText (including if the child specifies `textDecorationLine: "none"`. The new behavior is consistent with both iOS and web though, so it seems like more of a bugfix than a regression.

Changelog:
[Android][Fixed] - Minimize Spans 5/N: Strikethrough and Underline

Reviewed By: rshest

Differential Revision: D44240778

fbshipit-source-id: d564dfc0121057a5e3b09bb71b8f5662e28be17e
@NickGerleman @kelset
Minimize EditText Spans 6/9: letterSpacing (facebook#36548)
7f10090 
Summary:
Pull Request resolved: facebook#36548

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This change lets us set `letterSpacing` on the EditText instead of using our custom span.

Changelog:
[Android][Fixed] - Minimize EditText Spans 6/N: letterSpacing

Reviewed By: rshest

Differential Revision: D44240777

fbshipit-source-id: 9bd10c3261257037d8cacf37971011aaa94d1a77
@NickGerleman @kelset
Minimize EditText Spans 7/9: Avoid temp list (facebook#36576)
3b07e7e 
Summary:
Pull Request resolved: facebook#36576

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This change addresses some minor CR feedback and removes the temporary list of spans in favor of applying them directly.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D44295190

fbshipit-source-id: bd784e2c514301d45d0bacd8ee6de5c512fc565c
@NickGerleman @kelset
Minimize EditText Spans 8/9: CustomStyleSpan (facebook#36577)
e89f919 
Summary:
Pull Request resolved: facebook#36577

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.

This change allows us to strip CustomStyleSpan. We already set all but `fontVariant` on the underlying EditText, so we just need to route that through as well.

Note that because this span is non-parcelable, it is seemingly not subject to the buggy behavior on Samsung devices of infinitely cloning the spans, but non-parcelable spans have different issues on the devices (they disappear), so moving `fontVariant` to the top-level makes sense here.

Changelog:
[Android][Fixed] - Minimize EditText Spans 8/N: CustomStyleSpan

Reviewed By: javache

Differential Revision: D44297384

fbshipit-source-id: ed4c000e961dd456a2a8f4397e27c23a87defb6e
@kelset
Merge pull request facebook#37084 from facebook/kelset/068-backport-s…
558bc33 
…amsung-fixes
@cuva @kelset
Use logical operator instead of bit operation
c3ad8ec 
Summary:
I guess it's the same since we're working on a `bool` but... this causes some compilation error.

Changelog:
[General][iOS] - Fix compilation warning in yoga

Reviewed By: Andrey-Mishanin

Differential Revision: D35438992

fbshipit-source-id: 22bb848dfee435ede66af0a740605d4618585e18
[0.68.7] Bump version numbers
b97a328
@elliscwc @alphatrl
feat: iOS textinput highlight and return function
d90a045
@elliscwc @alphatrl
feat: Android changes
22e0717
@elliscwc @alphatrl
feat: Gapless underline text
2189391
@elliscwc @alphatrl
fix: Move to afterTextChanged
9e5dae3
@alphatrl
fix(xcode): backport Xcode 14.3 fix to 68
a945bf6
@alphatrl alphatrl force-pushed the taskade/release/0.68 branch from 7e7ea23 to a945bf6 Compare May 2, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alphatrl @fortmarek @NickGerleman @kelset @cuva @elliscwc