Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Textfield to v0.67 #3

Open
wants to merge 9 commits into
base: 0.67-stable
Choose a base branch
from

Conversation

alphatrl
Copy link
Collaborator

@alphatrl alphatrl commented Feb 16, 2022

Custom Textfield v1

React Native: v0.67.5

Features/Modifications:

  1. New editorInput props, for modified version of textinput
  2. Return key will not make new line
  3. Underline highlight
  4. Gapless underline taken from here

iOS Build

No additional steps needed

Android Build

Build AAR with docker reactnativecommunity/react-native-android with tag 4

docker run --rm --name rn-build -v $PWD:/pwd -w /pwd reactnativecommunity/react-native-android:4 /bin/sh -c "./gradlew installArchives"

Commit:

# create .aar, then:
git add android --force
git commit -m 'my release commit'
git push

From Building from source

jonathanmos and others added 9 commits March 18, 2022 00:40
Summary:
Added a null check to native.value in Switch to fix regression from RN 66 -> stuck operation in mViewCommandOperations list in Android Release on initial layout of a screen with Switch component. If approved, please incorporate this fix into an RN 66 release.

## Changelog
[Android][Fixed] - Added a null check to native.value in Switch to fix facebook#32594

Pull Request resolved: facebook#32602

Test Plan: To reproduce, put a log in UIViewOperationQueue in dispatchViewUpdates you can see that the RetryableMountingException is no longer thrown for a screen with the Switch component on Android Release. As a result, mViewCommandOperations no longer has a stuck operation on initial layout.

Reviewed By: charlesbdudley

Differential Revision: D34397788

Pulled By: lunaleaps

fbshipit-source-id: 1cee3516fb987942dfa50ad1f2d11c965a947f05
@alphatrl alphatrl force-pushed the taskade/release/0.67 branch from 654b883 to dfbff6e Compare November 11, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants