Save ('s') and restore ('u') support added (2nd try) #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing 'get_position' method is flawed in the following ways: * Naming: its setter is 'set_cursor_position', not 'set_position' * Abstraction leak: returns internal Win32 structure * There is no way to get adjusted cursor position * Receives handle, instead of on_stderr flag
There are no more uses of get_position in the code base, so it could be deprecated, and, possibly, removed in future
This was referenced Mar 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test and demo plus minor refactoring of ansitowin32
This is just a copy of @kgeorgiy's excellent #137. I copied his commits to this branch to make extra commits (e.g fixing conflicts) simpler than they would be on his fork's master.
TODO: There's some problem with CI, python versions don't exist on the specified OS variations. I'll go fix that separately first, in #403.
TODO: Review comments from #137 apply here too.