Cleans up some unused function params in BFF (kubeflow#450)

Signed-off-by: Alex Creasy <[email protected]>
tarilabs · Oct 4, 2024 · 9bcbfea · 9bcbfea
1 parent febed3a
commit 9bcbfea
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 22 deletions.
diff --git a/clients/ui/bff/internal/api/model_registry_handler.go b/clients/ui/bff/internal/api/model_registry_handler.go
@@ -8,7 +8,7 @@ import (
 
 type ModelRegistryListEnvelope Envelope[[]data.ModelRegistryModel, None]
 
-func (app *App) ModelRegistryHandler(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
+func (app *App) ModelRegistryHandler(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
 
 	registries, err := app.models.ModelRegistry.FetchAllModelRegistries(app.kubernetesClient)
 	if err != nil {

diff --git a/clients/ui/bff/internal/api/model_versions_handler.go b/clients/ui/bff/internal/api/model_versions_handler.go
@@ -46,7 +46,7 @@ func (app *App) GetModelVersionHandler(w http.ResponseWriter, r *http.Request, p
 	}
 }
 
-func (app *App) CreateModelVersionHandler(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
+func (app *App) CreateModelVersionHandler(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
 	client, ok := r.Context().Value(httpClientKey).(integrations.HTTPClientInterface)
 	if !ok {
 		app.serverErrorResponse(w, r, errors.New("REST client not found"))

diff --git a/clients/ui/bff/internal/data/model_version_test.go b/clients/ui/bff/internal/data/model_version_test.go
@@ -14,7 +14,7 @@ import (
 )
 
 func TestGetModelVersion(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelVersion()
 
@@ -39,7 +39,7 @@ func TestGetModelVersion(t *testing.T) {
 }
 
 func TestCreateModelVersion(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelVersion()
 
@@ -64,7 +64,7 @@ func TestCreateModelVersion(t *testing.T) {
 }
 
 func TestUpdateModelVersion(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelVersion()
 
@@ -92,7 +92,7 @@ func TestUpdateModelVersion(t *testing.T) {
 }
 
 func TestGetModelArtifactsByModelVersion(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelArtifactList()
 
@@ -143,7 +143,7 @@ func TestGetModelArtifactsByModelVersionWithPageParams(t *testing.T) {
 }
 
 func TestCreateModelArtifactByModelVersion(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelArtifact()
 

diff --git a/clients/ui/bff/internal/data/registered_model_test.go b/clients/ui/bff/internal/data/registered_model_test.go
@@ -14,7 +14,7 @@ import (
 )
 
 func TestGetAllRegisteredModels(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockRegisteredModelList()
 
@@ -60,7 +60,7 @@ func TestGetAllRegisteredModelsWithPageParams(t *testing.T) {
 }
 
 func TestCreateRegisteredModel(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockRegisteredModel()
 
@@ -85,7 +85,7 @@ func TestCreateRegisteredModel(t *testing.T) {
 }
 
 func TestGetRegisteredModel(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockRegisteredModel()
 
@@ -107,7 +107,7 @@ func TestGetRegisteredModel(t *testing.T) {
 }
 
 func TestUpdateRegisteredModel(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockRegisteredModel()
 
@@ -135,7 +135,7 @@ func TestUpdateRegisteredModel(t *testing.T) {
 }
 
 func TestGetAllModelVersions(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelVersionList()
 
@@ -188,7 +188,7 @@ func TestGetAllModelVersionsWithPageParams(t *testing.T) {
 }
 
 func TestCreateModelVersionForRegisteredModel(t *testing.T) {
-	gofakeit.Seed(0) //nolint:errcheck
+	_ = gofakeit.Seed(0)
 
 	expected := mocks.GenerateMockModelVersion()
 

diff --git a/clients/ui/bff/internal/mocks/k8s_mock.go b/clients/ui/bff/internal/mocks/k8s_mock.go
@@ -10,7 +10,7 @@ type KubernetesClientMock struct {
 	mock.Mock
 }
 
-func NewKubernetesClient(logger *slog.Logger) (k8s.KubernetesClientInterface, error) {
+func NewKubernetesClient(_ *slog.Logger) (k8s.KubernetesClientInterface, error) {
 	return &KubernetesClientMock{}, nil
 }
 

diff --git a/clients/ui/bff/internal/mocks/model_registry_client_mock.go b/clients/ui/bff/internal/mocks/model_registry_client_mock.go
@@ -21,32 +21,32 @@ func (m *ModelRegistryClientMock) GetAllRegisteredModels(_ integrations.HTTPClie
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) CreateRegisteredModel(client integrations.HTTPClientInterface, jsonData []byte) (*openapi.RegisteredModel, error) {
+func (m *ModelRegistryClientMock) CreateRegisteredModel(_ integrations.HTTPClientInterface, _ []byte) (*openapi.RegisteredModel, error) {
 	mockData := GetRegisteredModelMocks()[0]
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) GetRegisteredModel(client integrations.HTTPClientInterface, id string) (*openapi.RegisteredModel, error) {
+func (m *ModelRegistryClientMock) GetRegisteredModel(_ integrations.HTTPClientInterface, _ string) (*openapi.RegisteredModel, error) {
 	mockData := GetRegisteredModelMocks()[0]
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) UpdateRegisteredModel(client integrations.HTTPClientInterface, id string, jsonData []byte) (*openapi.RegisteredModel, error) {
+func (m *ModelRegistryClientMock) UpdateRegisteredModel(_ integrations.HTTPClientInterface, _ string, _ []byte) (*openapi.RegisteredModel, error) {
 	mockData := GetRegisteredModelMocks()[0]
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) GetModelVersion(client integrations.HTTPClientInterface, id string) (*openapi.ModelVersion, error) {
+func (m *ModelRegistryClientMock) GetModelVersion(_ integrations.HTTPClientInterface, _ string) (*openapi.ModelVersion, error) {
 	mockData := GetModelVersionMocks()[0]
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) CreateModelVersion(client integrations.HTTPClientInterface, jsonData []byte) (*openapi.ModelVersion, error) {
+func (m *ModelRegistryClientMock) CreateModelVersion(_ integrations.HTTPClientInterface, _ []byte) (*openapi.ModelVersion, error) {
 	mockData := GetModelVersionMocks()[0]
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) UpdateModelVersion(client integrations.HTTPClientInterface, id string, jsonData []byte) (*openapi.ModelVersion, error) {
+func (m *ModelRegistryClientMock) UpdateModelVersion(_ integrations.HTTPClientInterface, _ string, _ []byte) (*openapi.ModelVersion, error) {
 	mockData := GetModelVersionMocks()[0]
 	return &mockData, nil
 }
@@ -56,7 +56,7 @@ func (m *ModelRegistryClientMock) GetAllModelVersions(_ integrations.HTTPClientI
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) CreateModelVersionForRegisteredModel(client integrations.HTTPClientInterface, id string, jsonData []byte) (*openapi.ModelVersion, error) {
+func (m *ModelRegistryClientMock) CreateModelVersionForRegisteredModel(_ integrations.HTTPClientInterface, _ string, _ []byte) (*openapi.ModelVersion, error) {
 	mockData := GetModelVersionMocks()[0]
 	return &mockData, nil
 }
@@ -66,7 +66,7 @@ func (m *ModelRegistryClientMock) GetModelArtifactsByModelVersion(_ integrations
 	return &mockData, nil
 }
 
-func (m *ModelRegistryClientMock) CreateModelArtifactByModelVersion(client integrations.HTTPClientInterface, id string, jsonData []byte) (*openapi.ModelArtifact, error) {
+func (m *ModelRegistryClientMock) CreateModelArtifactByModelVersion(_ integrations.HTTPClientInterface, _ string, _ []byte) (*openapi.ModelArtifact, error) {
 	mockData := GetModelArtifactMocks()[0]
 	return &mockData, nil
 }