chore!: rename generator #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
added a commit
that referenced
this pull request
Jul 3, 2024
Earlier work in #91, which renamed a generator, missed one instance in the documentation. This PR fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel proofs support the use of separate generators for verification and auxiliary verification keys. Currently, the notation
His used for the latter, which may be confusing depending on use case by conflicting with other notation (like Pedersen commitments).This PR renames the generator to
G1, which is also more in line with how input sets are defined. Note that this is also reflected in proof transcripts.BREAKING CHANGE: Changes the public API for parallel proofs. Existing proofs will not verify.