feat: Gray code indexing #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
gray
branch
2 times, most recently
from
283e454
to
45548a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During verification, the verifier must compute a product of
fterms that depends on index decomposition. This ends up being quite inefficient.As noted in #16, it's possible to replace standard index decomposition with a Gray code design. This is beneficial since successive indexes will differ only in a single digit. This means that successive products of
fterms can be computed with only two multiplications, one of which is the inverse of a scalar element off. We can further take advantage of the curve library's scalar batch inversion functionality to efficiently compute all such inverses at once.This PR adds this functionality. It introduces a new
GrayIteratorthat iteratively identifies digit changes between successive index decompositions, and modifies the prover and verifier to account for the change.Closes #16.