new Documentation for setting amount of threads used in STARDIS simul… #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jvshields
reviewed
Nov 4, 2024
| @@ -0,0 +1,63 @@ | |||
| { | |||
There was a problem hiding this comment.
I would add a note that this helps when computing spectra with large numbers of wavelength points (i.e., more than 10,000 or so), and it specifically parallelizes the line opacity calculation and ray tracing steps.
Reply via ReviewNB
There was a problem hiding this comment.
added in 'more info added: parallelized stuff and when to use'
jvshields
reviewed
Nov 5, 2024
andrewfullard
approved these changes
Nov 18, 2024
jvshields
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation
📝 Description
Type: 📝
documentationFirst draft of documentation that explains
n_threads: <integer>in yaml files, so how to set the number of threads used in a STARDIS simulation. Make sure I used terminology right, and there are probably more technical ways to phrase some parts. Also this documentation is very short, later it might want to be bundled into a larger notebook that covers similar features. This notebook is also just put in a new directory and will probably need a better place to live in the program.Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel