Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current tardis #142

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Oct 27, 2023

📝 Description

Type: 🚀 update

This pull request updates the version of the tardis dependency for stardis to the current one, rather than an old pinned one.

This pull request also updates all Python packages to current versions except for qgrid.

The environment now mirrors what is in the tardis repository

📌 Resources

Using sed to find and replace with the following commands (run from the root directory):

$ find . -type f -name "*.py" -exec sed -i 's/tardis.io.config_validator/tardis.io.configuration.config_validator/g' {} +
$ find . -type f -name "*.py" -exec sed -i 's/tardis.io.config_reader/tardis.io.configuration.config_reader/g' {} +

🚦 Testing

How did you test these changes?

  • Testing pipeline

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #142 (e7093a5) into main (a20f718) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head e7093a5 differs from pull request most recent head ef7c4fe. Consider uploading reports for the commit ef7c4fe to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   68.15%   68.19%   +0.03%     
==========================================
  Files          27       27              
  Lines         983      984       +1     
==========================================
+ Hits          670      671       +1     
  Misses        313      313              
Files Coverage Δ
stardis/base.py 95.34% <100.00%> (+0.11%) ⬆️
...adiation_field/opacities/opacities_solvers/base.py 81.31% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smokestacklightnin smokestacklightnin marked this pull request as ready for review October 30, 2023 19:12
andrewfullard
andrewfullard previously approved these changes Oct 30, 2023
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@jvshields jvshields added the benchmarks Trigger benchmarks to run on this pr label Oct 30, 2023
@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing main (a20f718) and the latest commit (ef7c4fe).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json

All benchmarks:

· Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json

@andrewfullard andrewfullard merged commit febe678 into tardis-sn:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Trigger benchmarks to run on this pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants