-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export raw Chianti collision and A_ul data instead of pre-processing #414
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 66.68% 67.38% +0.70%
==========================================
Files 46 46
Lines 3497 3462 -35
==========================================
+ Hits 2332 2333 +1
+ Misses 1165 1129 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should think about if we want to leave the old carsus interpolation as a deprecated format so people can still generate the same atomic data they were doing before. Potentially important for reproducing old results, though if it's too painful maybe we just tell people to use old carsus instead. |
📝 Description
Type: ☣️
breaking change
The Chianti data was previously processed in Carsus to work with TARDIS. With the latest changes to TARDIS in tardis-sn/tardis#2770 this will not be necessary, and TARDIS will handle the processing.
For the Einstein A_ul coefficients, Chianti has some levels with gf = 0. This means that A_ul is computed to be zero even if the levels are included. Changes in this PR allow the Chianti A_ul values to be retained. This probably breaks for CMFGEN data.
SHOULD ONLY BE MERGED IN CONJUNCTION WITH tardis-sn/tardis#2896
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label