integrity: consider 'instances.enabled' directory #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
11 times, most recently
from
5a178ba to
b23236e
Compare
| // InitializeIntegrityCheck is a noop setup of integrity checking. | ||
| func InitializeIntegrityCheck(publicKeyPath, configDir string) (IntegrityCtx, error) { | ||
| func InitializeIntegrityCheck( | ||
| publicKeyPath, configDir, instancesEnabledDir string, |
patapenka-alexey
approved these changes
Dec 12, 2025
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
2 times, most recently
from
dc0f4fb to
029b780
Compare
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
7 times, most recently
from
39f58b2 to
502f012
Compare
Adjust API of integrity library which is common for CE/EE. It doesn't affect functionality of CE at all, but is needed to implement lack of functionality in EE. Needed for TNTP-5214
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
3 times, most recently
from
5a53d26 to
0bea542
Compare
follow-up 331436c applying the approach introduced in 97f88ec `lib/dial` is used instead of `tls-dialer` because the latter depends on OpenSSL c-library and thus tt-executable requires `libssl.so`. Certain version of the SSL library `tt` will require depends on the build environment and if a target system don't have it, executable will fail to launch. This exact problem is reproduced for example when one tries to install `tarantool` using docker like: $ tt install tarantool --use-docker Docker image used internally by `tt` based on Ubuntu 18.04 and have SSL of version 1 onboard while modern environment use SSL of version 3, so the mentioned command fails in any modern environment. Closes #1220
Prior to this patch integration test `test_install_tarantool_in_docker` checked doesn't specify tarantool version explicitly, so it was always checked against the latest one. Which means that it might fail due to some problem introduced in tarantool and thus broke `tt` release cycle with non-tt problem. To avoid such an unpredictable behavior this test is adjusted to check only against predefined `tarantool` versions (each of them is obtained from the corresponding test environment). Original test that checks against the latest `tarantool` version is to be moved to separate workflow that is not involved into release cycle and is performed periodically (by cron) to monitor consistency. Closes #1221
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
from
0bea542 to
346d022
Compare
elhimov
force-pushed
the
elhimov/tntp-5214-failed-pack-tdb-with-integrity
branch
from
346d022 to
0123212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust API of integrity library which is common for CE/EE. It doesn't affect functionality of CE at all, but is needed to implement lack of functionality in EE.
I didn't forget about:
Related issues:
Part of TNTP-5214
Closes #1220
Closes #1221
Closes #1222
Related to tarantool/tarantool#12167