Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uninstall: fix uninstalling if no symlink in bin_dir #1083

Merged
merged 1 commit into from
Jan 29, 2025
Merged

uninstall: fix uninstalling if no symlink in bin_dir #1083

merged 1 commit into from
Jan 29, 2025
+40 −10

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Jan 15, 2025

Closes #900

@elhimov
Copy link
Contributor Author

elhimov commented Jan 15, 2025 •
edited
Loading

Original PR - #997 (closed because there is no way to update it as it has been made in fork)

@elhimov elhimov marked this pull request as draft January 16, 2025 16:13
@elhimov elhimov force-pushed the dvinogradov/gh-900-uninstall-doesnt-work-if-no-symlink branch from b070db5 to 2aff40e Compare January 28, 2025 09:52
@elhimov elhimov marked this pull request as ready for review January 28, 2025 09:53
@elhimov elhimov requested a review from dmyger January 28, 2025 09:54
@elhimov elhimov added the full-ci Enables full ci tests label Jan 28, 2025
patapenka-alexey
patapenka-alexey approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmyger dmyger merged commit b4b4c9a into master Jan 29, 2025
44 checks passed
@dmyger dmyger deleted the dvinogradov/gh-900-uninstall-doesnt-work-if-no-symlink branch January 29, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec left review comments

@patapenka-alexey patapenka-alexey patapenka-alexey approved these changes

@dmyger dmyger dmyger approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tt uninstall does not work if no symlink in bin_dir
5 participants
@elhimov @dmyger @oleg-jukovec @patapenka-alexey @Japsty