Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play: support tls options #1078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patapenka-alexey
Copy link
Contributor

@patapenka-alexey patapenka-alexey commented Jan 3, 2025

play: add TLS options

@TarantoolBot document
Title: play: add TLS options

This patch adds support of the ssl parameters to the tt play command
by using flags:
sslkeyfile - path to a private SSL key file,
sslcertfile - path to an SSL certificate file,
sslcafile - path to a trusted certificate authorities (CA) file,
sslciphers - colon-separated (:) list of SSL cipher suites the connection.

Closes #1067

@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/gh-1067-play-support-tls-options branch 3 times, most recently from 8643840 to 1a79b61 Compare January 3, 2025 09:26
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a list of new flags to the TarantoolBot comment.

cli/checkpoint/lua/play.lua Outdated Show resolved Hide resolved
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/gh-1067-play-support-tls-options branch 2 times, most recently from 278454a to bf6bb5f Compare January 3, 2025 12:06
CHANGELOG.md Outdated Show resolved Hide resolved
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/gh-1067-play-support-tls-options branch from bf6bb5f to 80530d4 Compare January 8, 2025 05:35
}
)
else
-- old versions of the netbox.connect() use specific params
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- old versions of the netbox.connect() use specific params
-- Old versions of the netbox.connect() use specific params

Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't forget to fix the comment.

@TarantoolBot document
Title: play: add TLS options

This patch adds support of the ssl parameters to the `tt play` command
by using flags:
  `sslkeyfile` - path to a private SSL key file,
  `sslcertfile` - path to an SSL certificate file,
  `sslcafile` - path to a trusted certificate authorities (CA) file,
  `sslciphers` - colon-separated (:) list of SSL cipher suites the
connection.

Closes #1067
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/gh-1067-play-support-tls-options branch from 80530d4 to 1d3e270 Compare January 8, 2025 08:00
@oleg-jukovec oleg-jukovec added the full-ci Enables full ci tests label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play: support TLS options
2 participants