Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0: fix tests used in doc samples #3771

Merged
merged 4 commits into from
Dec 26, 2023
Merged

3.0: fix tests used in doc samples #3771

merged 4 commits into from
Dec 26, 2023

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Oct 16, 2023

Fixed several issues in tests related to changes in Luatest (version 1.0) and Tarantool 3.0:

Luatest

  • Removing temp files.

Tarantool

  • A message in constraint errors is changed.
  • Names used in SQL samples are lower-case now.
  • The box.tuple.new syntax is updated.

Examples of doc pages that reference fixed samples:

image

@andreyaksenov andreyaksenov marked this pull request as ready for review December 26, 2023 12:42
@andreyaksenov andreyaksenov changed the title 3.0: fix constraint tests 3.0: fix tests used in doc samples Dec 26, 2023
Copy link

@ochaplashkin ochaplashkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
The tests were changed due to the presence of a defect in the luatest.

@andreyaksenov andreyaksenov merged commit f8f05c4 into 3.0 Dec 26, 2023
1 check passed
@andreyaksenov andreyaksenov deleted the 3.0-fix-tests branch December 26, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing tests for samples in 3.0 docs
2 participants