enh: check user name of consumer object directly.

[kailixu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @kailixu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves resource management by implementing a mechanism to automatically clear all associated consumers when a user is dropped from the system. This ensures that no lingering consumer resources remain, leading to a cleaner and more efficient system state after user removal operations.

Highlights

• New Functionality for Consumer Cleanup: Introduced a new function, mndDropConsumerByUser, responsible for identifying and clearing consumers associated with a specific user.
• Integration with User Dropping Process: The mndDropUser function now invokes mndDropConsumerByUser to ensure that all consumers owned by a user are properly cleared when that user is removed from the system.
• Resource Management Improvement: This change prevents orphaned consumer resources and enhances overall system hygiene by ensuring a complete cleanup during user deletion.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds functionality to clear consumers associated with a user when that user is dropped. The implementation introduces a new function mndDropConsumerByUser which iterates through consumers and sends a clear message for those owned by the user being dropped. The changes look good overall. I have a couple of suggestions to improve code robustness and simplify logic.

[Copilot]

Pull request overview

This pull request adds functionality to automatically clear consumers when a user is dropped from the system. This prevents orphaned consumers from remaining after their owning user has been deleted.

Changes:

• Added a new function mndDropConsumerByUser() to iterate through consumers and send clear messages for those owned by the user being dropped
• Integrated consumer cleanup into the user drop transaction flow
• Added the function declaration to the public header file

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
source/dnode/mnode/impl/src/mndUser.c	Integrated consumer cleanup into the user drop flow by calling mndDropConsumerByUser before transaction preparation
source/dnode/mnode/impl/src/mndConsumer.c	Implemented mndDropConsumerByUser function to iterate through consumers and send clear messages for those owned by the user
source/dnode/mnode/impl/inc/mndConsumer.h	Added public function declaration for mndDropConsumerByUser

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.