fix: group_concat type error #34443
Merged
fix: group_concat type error #34443
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a GROUP_CONCAT setup/type initialization bug and adds a regression query to ensure the function can be planned/executed with non-string inputs.
Changes:
- Fix
gconcatFunctionSetupto zero-initialize the correct result struct size. - Extend the aggregate test to create a STABLE and run a
GROUP_CONCAT(CAST(... AS VARCHAR))query.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/cases/11-Functions/02-Aggregate/test_agg_gconcat.py | Adds a regression query (and supporting STABLE) intended to exercise GROUP_CONCAT type handling. |
| source/libs/function/src/builtinsimpl.c | Fixes incorrect memset size for GROUP_CONCAT result state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guanshengliang
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.