fix: auth may miss cache when check use db for insert

[kailixu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @kailixu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial defensive programming measure by adding a null pointer check for the pConn parameter in the ctgChkAuth function. This change aims to enhance the robustness and stability of the system by preventing crashes that could arise from attempting to dereference a null pointer, thereby improving overall reliability.

Highlights

• Null Pointer Check: A null pointer check has been added for the pConn parameter within the ctgChkAuth function in catalog.c to prevent potential dereference issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR adds a null pointer check for the pConn parameter in the ctgChkAuth function to prevent potential null pointer dereference. The function is designed to handle both scenarios: fetching authorization info from the server (when pConn is provided) and checking only from cache (when pConn is NULL).

Changes:

• Added null pointer check for pConn before using it to fetch auth info from mnode

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request correctly adds a null pointer check for pConn in ctgChkAuth to prevent a potential crash. The fix is sound and effectively addresses the issue. I have one minor suggestion to improve code clarity and robustness.

[gemini-code-assist]

For improved clarity and robustness, it's better to return the explicit constant TSDB_CODE_SUCCESS rather than the variable code. Although code is 0 at this point, using the constant makes the function's intent more explicit and protects against future code modifications that might inadvertently change the value of code before this check.

  if (!pConn) return TSDB_CODE_SUCCESS;