-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: update links in user and permission management documentation #34437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for user and permission management within TDengine. The primary goal is to enhance the user experience by correcting internal navigation links and improving the overall readability through minor formatting adjustments in both English and Chinese documentation sets. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates links and cleans up formatting in the user and permission management documentation. The changes in the English documentation look good, with an updated link pointing to a more stable slug-based URL. However, the corresponding link update in the Chinese documentation (docs/zh/08-operation/14-user.md) appears to introduce a broken link. I've left a specific comment with details. The other formatting changes that remove extra blank lines are fine.
docs/zh/08-operation/14-user.md
Outdated
| 从 3.4.0.0 开始,TDengine 企业版通过基于角色的访问控制(RBAC)实现了三权分立机制,将 root 用户的管理权限拆分为 SYSDBA、SYSSEC 和 SYSAUDIT 三种系统管理权限,从而实现权限的有效隔离和制衡。 | ||
|
|
||
| 详细内容请参考 [权限管理](../14-reference/03-taos-sql/61-grant) 部分 No newline at end of file | ||
| 详细内容请参考 [权限管理](../reference/taos-sql/grant) 部分 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated link ../reference/taos-sql/grant appears to be incorrect. Based on the current file's location, this relative path points to docs/zh/reference/taos-sql/grant.md, which doesn't seem to exist in the repository structure provided. The original link ../14-reference/03-taos-sql/61-grant pointed to docs/zh/14-reference/03-taos-sql/61-grant.md, which seems correct. Please verify and fix the link path. For consistency with the English documentation, consider using absolute paths or slugs if your documentation framework supports it for Chinese documents as well.
| 详细内容请参考 [权限管理](../reference/taos-sql/grant) 部分 | |
| 详细内容请参考 [权限管理](../14-reference/03-taos-sql/61-grant) 部分 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates internal documentation links in user and permission management documentation to use correct URL-based paths and removes extraneous blank lines for better consistency.
Changes:
- Updated link to permission management documentation in Chinese and English user guide files
- Removed extra blank lines in Chinese and English grant.md files for cleaner formatting
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/zh/14-reference/03-taos-sql/61-grant.md | Removed extra blank lines (whitespace cleanup) |
| docs/zh/08-operation/14-user.md | Updated link from file path to URL path format (../reference/taos-sql/grant) |
| docs/en/14-reference/03-taos-sql/61-grant.md | Removed extra blank lines (whitespace cleanup) |
| docs/en/08-operation/14-user.md | Updated link to use absolute slug path (/tdengine-reference/sql-manual/manage-permissions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.