fix(tmq): decode heartbeat msg error if there is a consumer #34430

wangmm0220 · 2026-01-28T11:27:19Z

Description

Issue(s)

Close/close/Fix/fix/Resolve/resolve: Issue Link
https://project.feishu.cn/taosdata_td/defect/detail/6741681950

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

gemini-code-assist · 2026-01-28T11:27:32Z

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the TMQ consumer initialization process. Previously, consumers were incorrectly using a TMQ-specific connection type, leading to errors when decoding heartbeat messages. The change ensures that consumers establish connections using the appropriate query connection type, thereby resolving the decoding issue and improving the stability of TMQ consumer operations.

Highlights

TMQ Consumer Connection Fix: Corrected the connection type used when initializing a new TMQ consumer from 'CONN_TYPE__TMQ' to 'CONN_TYPE__QUERY' to resolve a heartbeat message decoding error.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request addresses a bug related to heartbeat message decoding errors when a TMQ consumer is present. The fix involves changing the connection type from CONN_TYPE__TMQ to CONN_TYPE__QUERY within the tmq_consumer_new function. This change appears to be a clean and effective solution. By aligning the TMQ consumer's connection type with that of regular query connections, it likely ensures that the server sends a consistent heartbeat response format to all connections within the same application instance, thus preventing decoding errors on the client side. The dedicated heartbeat mechanism for TMQ seems to be independent and should not be affected by this change. The fix is concise and well-targeted.

Copilot

Pull request overview

This pull request changes the connection type used when creating TMQ consumers from CONN_TYPE__TMQ to CONN_TYPE__QUERY. According to the PR title, this aims to fix a "decode heartbeat msg error if there is a consumer".

Changes:

Modified tmq_consumer_new() function in source/client/src/clientTmq.c to use CONN_TYPE__QUERY instead of CONN_TYPE__TMQ when establishing the internal connection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T11:30:13Z

source/client/src/clientTmq.c


  // init connection
-  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__TMQ, &pTmq->pTscObj);
+  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__QUERY, &pTmq->pTscObj);


The PR title mentions "decode heartbeat msg error if there is a consumer" but the description provides no details about what decoding error occurred or why changing from CONN_TYPE__TMQ to CONN_TYPE__QUERY fixes it.

Investigation shows that both connection types use identical heartbeat handlers (clientHb.c:1166-1170) and are processed identically during serialization/deserialization (tmsg.c:256,326). The main observable difference is that TMQ consumers will now appear as "QUERY" connections instead of "TMQ" connections in monitoring views (mndProfile.c:1011).

This change may be masking a root cause rather than addressing it properly. Please provide:

A detailed description of the heartbeat decoding error that was occurring

The specific scenario or conditions under which the error manifests

Why changing the connection type fixes the issue

Whether there are any side effects of TMQ consumers being identified as QUERY connections

Reference to the issue being fixed

Suggested change

code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__QUERY, &pTmq->pTscObj);

code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__TMQ, &pTmq->pTscObj);

Copilot · 2026-01-28T11:30:14Z

source/client/src/clientTmq.c


  // init connection
-  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__TMQ, &pTmq->pTscObj);
+  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__QUERY, &pTmq->pTscObj);


Changing the connection type from CONN_TYPE__TMQ to CONN_TYPE__QUERY will cause TMQ consumers to be misidentified as QUERY connections in system monitoring views. This affects observability - administrators and monitoring tools will no longer be able to distinguish TMQ consumer connections from regular query connections when viewing connection information.

Reference: mndProfile.c:1011 shows that connection types are used to label connections as "QUERY", "TMQ", or "UNKNOWN" in system views. After this change, all TMQ consumers will be labeled as "QUERY" connections.

If this change is intentional to work around an issue, it should be:

Clearly documented in the code with a comment explaining why

Accompanied by a plan to restore proper TMQ connection identification

Validated that monitoring and management tools can still properly handle TMQ operations

Copilot · 2026-01-28T11:30:14Z

source/client/src/clientTmq.c


  // init connection
-  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__TMQ, &pTmq->pTscObj);
+  code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__QUERY, &pTmq->pTscObj);


The PR description is incomplete. It does not provide:

A description of the actual changes made

The issue being fixed (no issue link provided)

Why this change is necessary

What the "decode heartbeat msg error" mentioned in the title refers to

Any potential side effects or implications of the change

A complete PR description should help reviewers understand the context, motivation, and impact of the changes. Please update the description to include this information.

fix(tmq): decode heartbeat msg error if there is a consumer

0d4d414

wangmm0220 requested a review from guanshengliang as a code owner January 28, 2026 11:27

Copilot AI review requested due to automatic review settings January 28, 2026 11:27

wangmm0220 requested review from dapan1121 and hzcheng as code owners January 28, 2026 11:27

Copilot started reviewing on behalf of wangmm0220 January 28, 2026 11:27 View session

taosdata-bot bot added the team engine label Jan 28, 2026

gemini-code-assist bot reviewed Jan 28, 2026

View reviewed changes

Copilot AI reviewed Jan 28, 2026

View reviewed changes

guanshengliang approved these changes Jan 29, 2026

View reviewed changes

guanshengliang merged commit 2ef0498 into 3.3.6 Jan 29, 2026
19 checks passed

guanshengliang deleted the fix/6741681950-336 branch January 29, 2026 01:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tmq): decode heartbeat msg error if there is a consumer #34430

fix(tmq): decode heartbeat msg error if there is a consumer #34430

wangmm0220 commented Jan 28, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__QUERY, &pTmq->pTscObj);
	code = taos_connect_internal(conf->ip, user, pass, NULL, NULL, conf->port, CONN_TYPE__TMQ, &pTmq->pTscObj);

fix(tmq): decode heartbeat msg error if there is a consumer #34430

fix(tmq): decode heartbeat msg error if there is a consumer #34430

Conversation

wangmm0220 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue(s)

Checklist

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wangmm0220 commented Jan 28, 2026 •

edited

Loading