-
Notifications
You must be signed in to change notification settings - Fork 5k
feat/6747537673-add-doc-audit #34427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cadem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the security documentation to include crucial information regarding the compatibility of audit databases across different software versions. The primary goal is to inform users about potential breaking changes when upgrading from versions prior to 3.4.0.0, ensuring they understand the implications for their existing audit databases and the necessary steps to maintain functionality or migrate their data. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation regarding the compatibility of audit databases between versions. The added text in both English and Chinese documents could be confusing for users as it presents seemingly contradictory instructions. I've suggested clearer wording for both files to present the information as distinct options with clear outcomes, improving readability and user understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds documentation about audit database compatibility issues between versions before and after 3.4.0.0. The documentation explains the incompatibility, migration requirements, and provides a workaround using the auditUseToken parameter.
Changes:
- Added version compatibility notice for audit databases explaining incompatibility between pre-3.4.0.0 and post-3.4.0.0 versions
- Documented the migration requirement (drop and recreate) for pre-3.4.0.0 audit databases
- Provided workaround information using the auditUseToken parameter for users wanting to use legacy audit databases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| docs/zh/08-operation/16-security.md | Added Chinese documentation about audit database version compatibility and migration requirements |
| docs/en/08-operation/16-security.md | Added English documentation about audit database version compatibility and migration requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/zh/08-operation/16-security.md
Outdated
|
|
||
| 另外,作为审计库,keep 默认为 1825d,如果用户指定 keep,要求大于 1825d;WAL_LEVEL 默认为 2,用户不能更改;ENCRYPT_ALGORITHM 用户不能指定为 None,可以选择任意一种 CBC 模式的对称加密算法。 | ||
|
|
||
| 在3.4.0.0之前的版本的审计库,与3.4.0.0之后的审计库不兼容,无法开启is_audit参数,也即没有对DURATION、WAL_LEVEL、ENCRYPT_ALGORITHM的强制要求。3.4.0.0之前的审计库只能drop后,重新创建审计库。如果要在3.4.0.0之后的版本中,使用3.4.0.0之前版本创建的审计库,需要将auditUseToken关闭,即设置为0。 |
Copilot
AI
Jan 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "无法开启is_audit参数" (cannot enable the is_audit parameter) is misleading. In pre-3.4.0.0 versions, the is_audit parameter CAN be used to create audit databases, but it doesn't enforce the mandatory requirements. Consider rephrasing to "is_audit参数不强制要求" (the is_audit parameter does not enforce requirements) to be more accurate.
| 在3.4.0.0之前的版本的审计库,与3.4.0.0之后的审计库不兼容,无法开启is_audit参数,也即没有对DURATION、WAL_LEVEL、ENCRYPT_ALGORITHM的强制要求。3.4.0.0之前的审计库只能drop后,重新创建审计库。如果要在3.4.0.0之后的版本中,使用3.4.0.0之前版本创建的审计库,需要将auditUseToken关闭,即设置为0。 | |
| 在3.4.0.0之前的版本的审计库,与3.4.0.0之后的审计库不兼容,is_audit参数不强制要求DURATION、WAL_LEVEL、ENCRYPT_ALGORITHM。3.4.0.0之前的审计库只能drop后,重新创建审计库。如果要在3.4.0.0之后的版本中,使用3.4.0.0之前版本创建的审计库,需要将auditUseToken关闭,即设置为0。 |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.