fix: join crash issue

[dapan1121]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @dapan1121, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a crash issue encountered during join operations by refining memory management within the query executor. It also introduces enhanced debugging configurations for join-related tests, which will aid in diagnosing and preventing similar issues in the future.

Highlights

• Memory Management Fix: Relocated the taosArrayDestroy call in dynqueryctrloperator.c to ensure correct memory deallocation timing, preventing potential crashes related to join operations.
• Debugging Configuration: Added updatecfgDict and clientCfgDict with debug flags to test_join_full.py to facilitate debugging and logging during join query tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a use-after-free crash in dynqueryctrloperator.c by moving the destruction of pUidList to after its last use. The change is sound. The modification in the Python test file enables debug flags, which was likely helpful for debugging. I've added a suggestion to refactor the test configuration for better readability and maintainability.

[Copilot]

Pull request overview

This pull request fixes a crash issue in join queries by correcting a use-after-free bug and adding debug configuration to the join test suite.

Changes:

• Fixed use-after-free bug in buildBatchExchangeOperatorParam where array was destroyed before being accessed in trace logging
• Added debug flag configurations to join test class to enable detailed logging for debugging join-related issues

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
source/libs/executor/src/dynqueryctrloperator.c	Moved taosArrayDestroy call after trace logging to prevent use-after-free
test/cases/14-JoinQueries/test_join_full.py	Added debug configuration dictionaries to enable detailed logging for join tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.