IOS-4136 Add ed25519 full support #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tureck1y
commented
Jul 31, 2023
tureck1y
commented
- добавилась новая кривая ed25519_slip0010, для нее подходит старая реализация импорта ключа
- добавлена новая реализация импорта ключа для ed25519
- отрефакторен импорт ключа
- удален интерфейс импорта с seed, потому что он больше не позволит создать ключ на любой кривой
- добавлены тесты
|
тесты пока будут падать, разбираемся |
megakoko
reviewed
Aug 3, 2023
|
|
||
| // generated by card | ||
| let publicKeyFromCard = "32EA4EE339B0B01233E5F0728D733DC68A26D17A58C140AA23FE1C8EEABD5ABE" | ||
| XCTAssertEqual(publicKeyFromCard.lowercased(), expectedPublicKey) |
There was a problem hiding this comment.
Два захардкоженных значения сравниваются
There was a problem hiding this comment.
Это статичные тесты на работу карты. Для новых прошивок тесты будут обновляться.
Balashov152
reviewed
Aug 3, 2023
|
megakoko
previously approved these changes
Aug 3, 2023
Balashov152
previously approved these changes
Aug 3, 2023
|
Тут все. Тесты переделал на спиппеты, пока тут, потом сложим в отдельный кит, либо прям в демо сдк. Еще добавил отдельный метод в утилиту для верификации подписи r1 |
megakoko
approved these changes
Aug 7, 2023
Comment on lines
+304
to
+308
| self.printEquals(expected1.publicKey.hexString, derived1.publicKey.hexString) | ||
| self.printEquals(expected1.chainCode.hexString, derived1.chainCode.hexString) | ||
|
|
||
| case .failure(let error): | ||
| print(error) |
There was a problem hiding this comment.
Без ассертов ошибки не затеряются?
There was a problem hiding this comment.
а это не юниты, так что ок
Balashov152
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.