IOS-8496 remove pending solana transaction #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
requested changes
Nov 26, 2024
|
|
||
| let mapper = PendingTransactionRecordMapper() | ||
| let record = mapper.mapToPendingTransactionRecord(transaction: transaction, hash: hash) | ||
| wallet.addPendingTransaction(record) |
There was a problem hiding this comment.
ну нет, этот код должен остаться и на апдейте пендинг нужно чистить
There was a problem hiding this comment.
ну нет, этот код должен остаться и на апдейте пендинг нужно чистить
Так , ну я убрал не спроста , сходил в Андроид , узнал что обсуждали с Денисом , и объяснили сделать именно так , завтра тогда уточню еще разок
There was a problem hiding this comment.
ну нет, этот код должен остаться и на апдейте пендинг нужно чистить
Может я конечно не так понял , но суть такая да , что транзакции становятся мгновенно , и подвешивать их смысла нет
tureck1y
approved these changes
Nov 28, 2024
Andoran90
approved these changes
Nov 28, 2024
fedorov-d
approved these changes
Nov 29, 2024
skibinalexander
deleted the
feature/IOS-8496_remove_pending_solana_transaction
branch
Andoran90
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Убираем pending транзакции для сокращения числа запросов. Транзакции считаем, что пролетают мгновенно
Рекомендация @dbaturin