IOS-8610 [Onramp] Possible to open onramp from Markets #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
reviewed
Nov 25, 2024
| coordinator.openOnramp(for: walletModel, with: userWalletModel) | ||
| } else { | ||
| // Old code | ||
| Analytics.log(event: .marketsChartButtonBuy, params: analyticsParams) |
There was a problem hiding this comment.
так аналитика наверное должна остаться независимо от тоггла? Надо все остальные места под тогглом чекнуть
There was a problem hiding this comment.
✅ Вообще там есть задача по аналитике у меня, пройдусь в рамках ее тоже
skibinalexander
previously approved these changes
Nov 26, 2024
AlekseiMuraveinik1
previously approved these changes
Nov 27, 2024
ba1ashov
dismissed stale reviews from AlekseiMuraveinik1 and skibinalexander
via
81f4d50
ba1ashov
force-pushed
the
bugfix/IOS-8610-Open-from-markets
branch
from
81f4d50 to
f4476c4
Compare
ba1ashov
force-pushed
the
bugfix/IOS-8610-Open-from-markets
branch
from
f4476c4 to
364ea89
Compare
ba1ashov
requested review from
tureck1y,
AlekseiMuraveinik1 and
skibinalexander
|
Обновил логику навигации, что бы на тоггл проверять чуть раньше |
tureck1y
approved these changes
Nov 27, 2024
AlekseiMuraveinik1
approved these changes
Nov 28, 2024
skibinalexander
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tangem.atlassian.net/browse/IOS-8610
https://tangem.atlassian.net/browse/IOS-8602