IOS-8413: [Tech] Migrate all remaining dependencies to SPM, get rid of Cocoapods #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
…ebase/Messaging` to SPM Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
added
WIP
…_to_spm Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
…ease build Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
…_to_spm Signed-off-by: Andrey Fedorov <[email protected]>
…_to_spm Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
commented
Nov 27, 2024
| @@ -19809,6 +19600,7 @@ | |||
| ENABLE_NS_ASSERTIONS = NO; | |||
| ENABLE_STRICT_OBJC_MSGSEND = YES; | |||
| ENABLE_USER_SCRIPT_SANDBOXING = NO; | |||
| EXCLUDED_SOURCE_FILE_NAMES = "GDPerformance*"; | |||
There was a problem hiding this comment.
Это убирает файлы из релизного бинарника, взято отсюда https://github.com/FLEXTool/FLEX?tab=readme-ov-file#flex-files-added-manually-to-a-project
Конфигурация и включение либы и так закрыты флагами ALPHA || BETA || DEBUG, но дополнительно тут вырезаются сорцы
m3g0byt3
commented
Nov 27, 2024
| isa = XCRemoteSwiftPackageReference; | ||
| repositoryURL = "https://github.com/tangem/firebase-ios-sdk.git"; | ||
| requirement = { | ||
| branch = "feature/IOS-8413_migrate_all_dependencies_to_spm"; |
m3g0byt3
commented
Nov 27, 2024
| isa = XCRemoteSwiftPackageReference; | ||
| repositoryURL = "https://github.com/tangem/BlockiesSwift.git"; | ||
| requirement = { | ||
| branch = "feature/IOS-8413_migrate_all_dependencies_to_spm"; |
m3g0byt3
commented
Nov 27, 2024
| "location" : "https://github.com/CombineCommunity/CombineExt.git", | ||
| "state" : { | ||
| "revision" : "d7b896fa9ca8b47fa7bcde6b43ef9b70bf8c1f56", | ||
| "version" : "1.8.1" |
There was a problem hiding this comment.
Через подсы стоял 1.8.0, чейнджи незначительные CombineCommunity/CombineExt@1.8.0...1.8.1
Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
changed the title
Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
changed the title
tureck1y
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOS-8413
Перенос оставшихся зависимостей в SPM и выпил Cocoapods
Зависит от:
swift-protobuf-binariesdependency (FB 10.29.0) firebase-ios-sdk#1