IOS-8548 Add fee zero token #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BlockchainSdk/Common/Address/AddressTypesConfig.swift # BlockchainSdk/Common/Blockchain.swift # BlockchainSdk/Common/Blockchain/Blockchain+AllCases.swift # BlockchainSdk/Common/Derivations/DerivationConfigV1.swift # BlockchainSdk/Common/Derivations/DerivationConfigV2.swift # BlockchainSdk/Common/Derivations/DerivationConfigV3.swift # BlockchainSdk/Common/Factories/AddressServiceFactory.swift # BlockchainSdk/Common/Factories/EstimationFeeAddressFactory.swift # BlockchainSdk/Common/Factories/ExternalLinkProviderFactory.swift # BlockchainSdk/Extensions/TWCoin+.swift # Tangem/App/Models/Config/SupportedBlockchains.swift # Tangem/App/Services/ExchangeService/MercuryoService.swift # Tangem/App/Services/ExchangeService/MoonPayService.swift # Tangem/App/Utilities/CustomTokenContractAddressConverter.swift # Tangem/App/Utilities/TokenInteractionAvailabilityProvider.swift # Tangem/Modules/Send/Services/TransactionParamsBuilder.swift # TangemApp.xcodeproj/project.pbxproj
# Conflicts: # tangem-app-config
# Conflicts: # TangemApp.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # BlockchainSdk/Common/Address/AddressTypesConfig.swift # BlockchainSdk/Common/Blockchain.swift # BlockchainSdk/Common/Blockchain/Blockchain+AllCases.swift # BlockchainSdk/Common/Derivations/DerivationConfigV1.swift # BlockchainSdk/Common/Derivations/DerivationConfigV2.swift # BlockchainSdk/Common/Derivations/DerivationConfigV3.swift # BlockchainSdk/Common/Factories/AddressServiceFactory.swift # BlockchainSdk/Common/Factories/EstimationFeeAddressFactory.swift # BlockchainSdk/Common/Factories/ExternalLinkProviderFactory.swift # BlockchainSdk/Extensions/TWCoin+.swift # Tangem/App/Models/Config/SupportedBlockchains.swift # Tangem/App/Services/ExchangeService/MercuryoService.swift # Tangem/App/Services/ExchangeService/MoonPayService.swift # Tangem/App/Utilities/CustomTokenContractAddressConverter.swift # Tangem/App/Utilities/TokenInteractionAvailabilityProvider.swift # Tangem/Modules/Send/Services/TransactionParamsBuilder.swift
skibinalexander
changed the base branch from
develop
to
test/ci_cd_builder2_tests_xcode_16_1
skibinalexander
changed the base branch from
test/ci_cd_builder2_tests_xcode_16_1
to
blockchains/xodex
# Conflicts: # Tangem/App/Services/ExchangeService/MercuryoService.swift
tureck1y
approved these changes
Nov 27, 2024
|
@Balashov152 @tureck1y посмотрите пожалуйста получше , SendFeeInteractor ничему не вредительствую? |
ba1ashov
reviewed
Nov 27, 2024
fedorov-d
approved these changes
Nov 28, 2024
ba1ashov
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача по итогам тестирования валюта.
В xodex отправка "дефолтных" токенов идет с комиссией 0 по монете. Попросили убрать нотификашку о том что нужна валюта.
Сделал generic флаг, для таких вещей. Draft так как планирую обсудить с @tureck1y , может можно будет как - то по красивее сделать