IOS-8315 Total balance include staked #4097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elete unused code
ba1ashov
reviewed
Oct 21, 2024
| import Foundation | ||
| import Combine | ||
|
|
||
| class SingleTokenTotalBalanceProvider { |
There was a problem hiding this comment.
А это разве не используется ?
There was a problem hiding this comment.
@Andoran90 это не ошибка?
There was a problem hiding this comment.
в этом то и вопрос, не используется по ошибке или просто забыли снести
There was a problem hiding this comment.
забыли снести думаю, довольно специфичная сущность, она по идее подходит для одновалюток и для деталки токена, но одновалютки используют общую реализацию, а деталка свою реализацию со стейкингом.
Andoran90
approved these changes
Oct 21, 2024
ba1ashov
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил зависимость от состояния стейкинг менеджера при подсчете total. Также удалил не используемый класс.