IOS-7990: [Markets] Fix navigation issues on iOS 18 #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
commented
Sep 18, 2024
Comment on lines
151
to
+158
| mainBottomSheetUIManager | ||
| .isShownPublisher | ||
| .filter { $0 } | ||
| .withWeakCaptureOf(self) | ||
| .map { coordinator, isShown in | ||
| return isShown ? coordinator.__marketsCoordinator : nil | ||
| .sink { coordinator, _ in | ||
| coordinator.setupMainBottomSheetCoordinatorIfNeeded() | ||
| } | ||
| .assign(to: \.marketsCoordinator, on: self, ownership: .weak) | ||
| .store(in: &bag) |
There was a problem hiding this comment.
Надо лениво создавать координатор, чтобы шторка не была видима на экране логина
Этого можно было бы избежать, если бы AppCoordinatorView дергала onChange(of: coordinator.isOverlayContentContainerShown) для initial state, но это ios 17+
Проверил - при разлогине у меня на 17 все ок, но надо проверить разлогин и на 18
оранжевый цвет - для дебага
Untitled.mp4
m3g0byt3
changed the title
…es_on_ios_18 Signed-off-by: Andrey Fedorov <[email protected]>
skibinalexander
previously approved these changes
Sep 18, 2024
… ones are broken on iOS 18+ Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
commented
Sep 18, 2024
Comment on lines
-65
to
-68
| .animation( | ||
| .easeInOut(duration: viewModel.overlayContentHidingAnimationDuration), | ||
| value: viewModel.overlayContentHidingProgress | ||
| ) |
There was a problem hiding this comment.
implicit animations сломались на 18 оси
…es_on_ios_18 Signed-off-by: Andrey Fedorov <[email protected]>
m3g0byt3
force-pushed
the
bugfix/IOS-7990_fix_navigation_issues_on_ios_18
branch
from
e0d8780
to
3b66800
Compare
skibinalexander
approved these changes
Sep 18, 2024
tureck1y
deleted the
bugfix/IOS-7990_fix_navigation_issues_on_ios_18
branch
Balashov152
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Andrey Fedorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOS-7990
Причина - при убирании из иерархии вьюх и последующем добавлении обратно nav view с уже открытым чилдом (деталкой маркетсов в данном случае) nav view восстанавливает весь навигационный стек с анимациями (на ios 17 и ниже было без анимаций, стек сразу восстанавливался).
Дело не в модельном слое, никакие координаторы/vm не умирают, то есть navigation links не меняют своего стейта - а в SUI
Поэтому нормальное и красивое убираение шита через published item пришлось заменить на флажок и скрытие вьюхи