Updating setup.cfg for new pep changes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2024 16:16
Added a horizontal bar chart (hbar)
|
Would be great if you could merge this. |
|
Hi, can you please point me to the pep that is offending? What is the error message? |
tammoippen
requested changes
Oct 9, 2024
plotille/_graphs.py
Outdated
|
|
||
| from ._colors import color | ||
| from ._figure import Figure | ||
| from ._input_formatter import InputFormatter | ||
| from ._util import hist as compute_hist | ||
|
|
||
|
|
||
| def hbar(counts, labels=Optional[List[str]], width=80, log_scale=False, linesep=os.linesep, |
There was a problem hiding this comment.
Please remove typing information. I intentionally put no typing info in this project for now.
plotille/_graphs.py
Outdated
|
|
||
| from ._colors import color | ||
| from ._figure import Figure | ||
| from ._input_formatter import InputFormatter | ||
| from ._util import hist as compute_hist | ||
|
|
||
|
|
||
| def hbar(counts, labels=Optional[List[str]], width=80, log_scale=False, linesep=os.linesep, |
There was a problem hiding this comment.
What is the difference between this and hist_aggregated? Is it removing the bins part and the addition of labels?
There was a problem hiding this comment.
Exactly. Just needed a horizontal bar chart for something.
|
Made the requested changes. Updated the setup.py with more info from your .toml. If that was redundant I can remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New horizontal bar chart (hbar)